feat(router): make platform domain configurable #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM, but I wish there were a |
Closed
|
@mboersma there will be. I'm in a race for feature parity with 1.x to avoid blocking any other end-to-end testing. I still intend to backfill tests pre-alpha. |
krancour
added a commit
that referenced
this pull request
Dec 8, 2015
feat(router): make platform domain configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, routable services could be annotated with a list of domains, but that meant if someone wanted to change their "platform domain," every routable service would require its annotations to be updated-- no bueno.
This PR allows the platform domain (e.g. example.com) to be configured at the router level and any "domains" defined on a routable application that do not contain any periods will be assumed to be subdomains of the platform domain when the router builds its configuration model.