Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seed-repo): add red "priority 0|1" labels #38

Merged
merged 1 commit into from Aug 24, 2016

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Aug 24, 2016

Priority 0 marks an issue that must be fixed immediately, and priority 1 is to be fixed in the next planned release. Ping @Joshua-Anderson @kmala @vdice.

See also deis/workflow#475.

@mboersma mboersma added this to the v2.5 milestone Aug 24, 2016
@mboersma mboersma self-assigned this Aug 24, 2016
@deis-bot
Copy link

@slack, @carmstrong and @jchauncey are potential reviewers of this pull request based on my analysis of git blame information. Thanks @mboersma!

@kmala kmala added the LGTM1 label Aug 24, 2016
@Joshua-Anderson
Copy link
Contributor

We should add the label to the list here: https://deis.com/docs/workflow/contributing/triaging-issues/#prioritizing-issues

@jchauncey
Copy link
Member

We should have further discussion about this. I think the term showstopper and p0 will be confusing over time. We should probably drop the term showstopper and assign levels of priority to all issues. This will help us further prioritize the backlog and make sure we are making progress on all levels of issues.

@Joshua-Anderson
Copy link
Contributor

Joshua-Anderson commented Aug 24, 2016

We talked about this a bit at the triage meeting. We decided that showstopper and p0 have different meanings. showstopper is specifically for release blocking issues, whereas p0 is just a top priority issue. I think more priority levels can be added, but the immediate need was some way to flag important bugs to investigate.

@jchauncey
Copy link
Member

jchauncey commented Aug 24, 2016

I would say that a showstopper issue should be relabled p0 and p1 issue would be things that we will address in the next release. This allows us to have a common naming scheme for all priority levels

Basically the levels would be as follows:

** EVERYTHING BELOW IS A SUGGESTION =P **

  • p0 - Issue that requires an immediate fix. This might be bugs like shellshock, security issues, or data loss. We would probably issue a patch release for this or if the release window is close enough we just roll forward with a minor release.
  • p1 - Issues that are given this label have severe consequences but may not require an immediate release of the product. This might be a user interface problem (cli flags not working) or edge cases of components not starting - resulting in a crashloop.
  • p2 - These issues are normally UX in nature or might cause dis-satisfaction for our users. They should be treated with a higher priority than other issues but are not a drop everything and fix. We should have a time table on how soon we fix a p2 issue.
  • p3 - These issues are minor and normally result in work that is a refactor or small enhancement. They can be used as filler work for a sprint.

@bacongobbler
Copy link
Member

bacongobbler commented Aug 24, 2016

I agree with @jchauncey. At this point a showstopper means "specifically for release blocking issues" and p0 means "an issue that must be fixed in the next product release", which means they both accomplish the same thing from my POV.

I realize I wasn't there for the triage meeting so my vote doesn't count, just thought I'd throw in my 2 cents about any future confusion towards these labels. We can just label everything p0 and showstopper though ;)

@jchauncey
Copy link
Member

I think my fear was that we would label everything as a p0/showstopper which makes 1 of them kind of pointless.

@mboersma
Copy link
Member Author

@jchauncey @bacongobbler of course your vote counts!

After more discussion, I think we decided on this:

  • "priority 0" means it's a 0-day, drop everything, maybe make a patch release type of fix
  • "priority 1" means it's a serious bug that will be fixed for the next planned release
  • "showstopper" is deprecated and will be removed eventually

I'll update this PR to add those labels, and create an associated docs PR clarifying their usage. But please continue the conversation here if I've missed something or if you think we should proceed in a different direction.

@bacongobbler
Copy link
Member

Nope! That sounds exactly like what we talked about in the standup. Sounds good to me :)

"priority 0" is a drop-everything, patch release type of issue.
"priority 1" is a serious issue to be fixed in the next release.
Priority 0 marks an issue that must be fixed in the next
product release.
@mboersma mboersma changed the title feat(seed-repo): add red "priority 0" label feat(seed-repo): add red "priority 0|1" labels Aug 24, 2016
@vdice vdice added the LGTM1 label Aug 24, 2016
@mboersma mboersma merged commit b88a929 into deis:master Aug 24, 2016
@mboersma mboersma deleted the priority-0 branch August 24, 2016 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants