Limit tests #230
Limit tests #230
Conversation
|
@Joshua-Anderson is a potential reviewer of this pull request based on my analysis of |
| }`) | ||
| }) | ||
|
|
||
| err = cmdr.UsersList(-1) |
There was a problem hiding this comment.
Do you want 1 here instead of -1?
|
One minor thing I noticed, otherwise LGTM. |
|
Nice catch @Joshua-Anderson. I'm going to spend a bit of time investigating why that was passing as it was written. But fixed. |
|
I'm thinking it was passing because the SDK returned |
|
Could you possibly add limits tests for |
|
I also noticed that we still need tests for limits on |
|
Thanks @Joshua-Anderson. Somehow missed the keys test. Added. |
|
After my changes to codecov, you need to rebase. Sorry! |
Current coverage is 26.88% (diff: 100%)@@ master #230 diff @@
==========================================
Files 56 56
Lines 3861 3861
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1009 1038 +29
+ Misses 2719 2684 -35
- Partials 133 139 +6
|
ultimateboy
force-pushed
the
limit-tests
branch
from
3554758
to
0208366
Compare
* tests(builds): add test for 'deis builds:list --limit' * tests(certs): add test for 'deis certs:list --limit' * tests(domains): add test for 'deis domains:list --limit' * tests(releases): add test for 'deis releases:list --limit' * tests(users): add test for 'deis users:list --limit' * tests(perms): add tests for 'deis perms:list' with and without '--limit' * fix(tests): correct test user limit * tests(keys): add test for 'deis keys:list --limit' * fix(tests): correct test for keys list. * tests(apps): add tests for 'apps:list' and 'apps:list --limit'
Fixes deis/workflow-e2e#196
Fixes deis/workflow-e2e#198
Fixes deis/workflow-e2e#199
Fixes deis/workflow-e2e#200
Fixes deis/workflow-e2e#201