This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
chore(release-checklist): Amend with steps for router chart #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| 5. Delete the `KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS` env var from `workflow-$WORKFLOW_RELEASE_SHORT/tpl/deis-controller-rc.yaml` | ||
|
|
||
| 6. Test the chart and make sure it installs: | ||
| 6. Test the new Workflow chart and make sure it installs: |
There was a problem hiding this comment.
fwiw, the change on this line is just meant to be specific about which chart, since the steps above produce three.
slack
pushed a commit
to slack/deis
that referenced
this pull request
Jun 6, 2016
slack
pushed a commit
to slack/deis
that referenced
this pull request
Jun 6, 2016
…remote fix(client): backport deis/workflow#280 to v1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.