Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Allows for proper parsing of charset #153

Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix(server): Allows for proper parsing of charset #153

merged 1 commit into from
Jun 10, 2021

Conversation

thomastaylor312
Copy link
Contributor

Closes #131

itowlson
itowlson approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me (though I don't know the code) - thanks!

@thomastaylor312 thomastaylor312 mentioned this pull request Jun 10, 2021
Closed
radu-matei
radu-matei approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomastaylor312 thomastaylor312 merged commit 3138383 into deislabs:main Jun 10, 2021
@thomastaylor312 thomastaylor312 deleted the fix/allow_charset branch June 10, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

@radu-matei radu-matei radu-matei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept charset in Content-Type header
3 participants
@thomastaylor312 @itowlson @radu-matei