feat(*): Adds bindle-keys endpoint support #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
requested review from
technosophos and
radu-matei
as code owners
|
I am going to be out of town for a bit so no rush on this, but I did want to get it open so people could take a look at it and review. The reason this is still a WIP is because I haven't written tests for the new CLI command. I will finish that when I get back |
dicej
reviewed
Jun 8, 2022
thomastaylor312
force-pushed
the
feat/bindle-keys
branch
from
c239338
to
08b0fff
Compare
thomastaylor312
changed the title
|
Sorry this took longer for me to come back around to. @technosophos or @radu-matei this needs a review! |
thomastaylor312
force-pushed
the
feat/bindle-keys
branch
from
08b0fff
to
1b0af6a
Compare
technosophos
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new
bindle-keysendpoint to the bindle server as well as client code for consuming that end point. Note that this has one small breaking change for therawmethod on theClient.I also fixed some clippy lints that had snuck past us