Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable containerd image store for docker #208

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Feb 5, 2024

Close #205

The containerd image store is required to load wasi/wasm images. For more info about the image store, you can read it here.

Regarding how to enable the image store in docker, please refer to this page.

Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
@Mossaka
Copy link
Member Author

Mossaka commented Feb 5, 2024

Could you please take a look? @rumpl

@rumpl
Copy link
Contributor

rumpl commented Feb 6, 2024

Another way to do this is with the setup-docker action https://github.com/docker/compose/pull/11046/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR234

but if this works then lgtm :)

@Mossaka
Copy link
Member Author

Mossaka commented Feb 6, 2024

Perhaps we can add this to build-push-action

@Mossaka Mossaka merged commit 3f15b84 into deislabs:main Feb 6, 2024
20 checks passed
@Mossaka Mossaka deleted the enable-image-store branch February 6, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The docker image CI is failing
2 participants