Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes proxy port in UI #251

Merged
merged 2 commits into from Sep 14, 2021
Merged

Conversation

simongdavies
Copy link
Member

@simongdavies simongdavies commented Sep 14, 2021

This is a temporary solution to the fact that we create a link to an app channel without the proxy port in the Hippo UI.

This is intended to be a good enough solution for v0.1.0 and will need re visiting when we ship external schedulers.

closes #140

Copy link
Contributor

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just had one point of feedback; otherwise this will certainly serve its purpose. Thanks!

Hippo/Views/Shared/_NavSidebar.cshtml Outdated Show resolved Hide resolved
@simongdavies simongdavies merged commit b05d33f into deislabs:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] display the port(s) that the reverse proxy is listening on to the Hippo Application.
2 participants