Fixes to bring this up to CGI/1.1 specification #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
radu-matei
reviewed
Aug 23, 2021
| # The value of the HTTP Accept header from the client. This could be empty. | ||
| HTTP_ACCEPT="*/*" | ||
| # The HTTP method (GET/POST/PUT/etc) sent by the client | ||
| REQUEST_METHOD="GET" | ||
| # The protocol that the server is using. Normally this is "http" or "https" | ||
| SERVER_PROTOCOL="http" | ||
| # The protocol that the server is using. Usually it is HTTP/1.1 |
There was a problem hiding this comment.
Should we mention it is always HTTP/1.1 for now?
Do we want to add a note in the docs about HTTP/2?
There was a problem hiding this comment.
I think I am going to leave it just b/c I know that Wagi.net points to these docs in some places. And IIRC, it can do HTTP/2
radu-matei
reviewed
Aug 23, 2021
radu-matei
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During investigation of #101, I found several fairly major discrepancies between Wagi and the CGI/1.1 specification. This fixes the following:
SCRIPT_NAMEis now correctly the path too the handler route (route minus/...)PATH_INFOis now correctly the path added after the handler route (e.g. whatever matched/...)PATH_TRANSLATEDis now correctly the URL-decoded value ofPATH_INFOStatusparser now allows there to be a message in addition to the code (e.g.Status 404 Not Found). However, the message is ignored, and the standard messages are used.Additionally:
X_RELATIVE_PATHhas been removed, replaced byPATH_INFOStatuswithout aContent-Type, I easily discovered cases in the wild where a CGI returnedStatus, and neither a body nor aContent-Type. We now allow this (which makes sense).Docs were updated accordingly
Closes #101
Signed-off-by: Matt Butcher matt.butcher@microsoft.com