Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(*): update bindle dependency and usage #152

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 1, 2022

This PR revs the Bindle dep up to the latest 0.8.0 version. In doing so, the following minimal set of updates were required:

  • Update usage of the Bindle client API. In this PR, I went the route of only making strictly necessary updates, which includes a no-auth approach for satisfying the needs of the client instantiation. If reviewers approve, I would create a follow-up issue around actually implementing support for auth methods that the client supports.
  • Add required fields to Invoice and Label objects
  • Update the version for the itowlson/toast-on-demand test bindle to satisfy semver constraints that came in as part of the Bindle update (semver crate was rev'd to 1.0.4)

Thanks again to @itowlson who made it possible to update the Bindle version! (deislabs/bindle#287)

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@vdice vdice merged commit 4d261cf into deislabs:main Feb 1, 2022
@vdice vdice deleted the ref/update-bindle branch February 1, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants