Migrate windows CI to Github Actions #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
migrate_windows_ci_to_gh_actions
branch
from
67861f0
to
6321d31
Compare
This spec used to load `abbrev` in the past. That was changed, but I forgot to update the message.
deivid-rodriguez
force-pushed
the
migrate_windows_ci_to_gh_actions
branch
4 times, most recently
from
96d3136
to
761d281
Compare
They make the CI more brittle because these files might not always be present.
deivid-rodriguez
force-pushed
the
migrate_windows_ci_to_gh_actions
branch
from
eff537f
to
9a214c7
Compare
This is simpler and also doesn't depend on hardcoded installation paths.
In other CI systems such as Github Actions, it's not as easy to persist environment variables across steps, so merging all these related steps to use the same shell makes migration easier.
deivid-rodriguez
force-pushed
the
migrate_windows_ci_to_gh_actions
branch
from
5821244
to
169b50f
Compare
I needed to workaround one test because on the Github Actions environment, the test path is not the last feature to have been loaded. The test is only concerned with it having been loaded, no matter in which position, so adapt the assertion.
deivid-rodriguez
force-pushed
the
migrate_windows_ci_to_gh_actions
branch
from
169b50f
to
f4d0f35
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.