-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ReadPos/Slice generic over Borrow and PosRead #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekellum
changed the title
Make ReadPos/Slice generic over Borrow<File>
Make ReadPos/Slice generic over Borrow and PosRead
May 16, 2018
As of 58b1f26, pub struct ReadPos<P>
where P: PosRead So these can own, for example via The existing rc::Read* types are left in place by type alias, e.g.: pub type ReadSlice = super::ReadSlice<Arc<File>>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, will summarize.As of 7e02853,
ReadPos
(andReadSlice
) are now generic over aBarrow
andPosRead
type, in the form:This allows ReadPos/Slice to support, for example, an owned file (
ReadPos<File, File>
) as well as by shared reference (ReadPos<File, &File>
orReadPos<File, Arc<File>>.
It also makes it possible for other (future) implementations ofPosRead
to share these types.For all but the owned case, a type is needed for
P
which can not be inferred, e.g.The existing rs::Read* types are left in place by type alias, e.g.:
This has been simplified, see update below.
A new
ReadSubSlice
trait must be imported to continue to usesubslice
. This is, strictly-speaking a breaking change.