Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse allows to walk on blocked tiles after path lands mouse on a blocked tile #8

Closed
naknode opened this issue Jan 5, 2018 · 4 comments
Closed

Mouse allows to walk on blocked tiles after path lands mouse on a blocked tile #8

naknode opened this issue Jan 5, 2018 · 4 comments
Labels
bug "Hey, that's not suppose to happen." canvas (Graphic) issues on the game canvas. easy Issue/feature that is easy to fix or implement. Good for 1st-time contributors. good first issue Easy issues that are excellent for people wanting to get in meat of the code. low priority Nice-to-have issues and features.
Milestone
v0.1.0

Comments

@naknode
Copy link
Member

naknode commented Jan 5, 2018 •
edited
Loading

Do you want to request a feature or report a bug?

bug

What is the current behavior?

When you right-click to walk somewhere, your mouse will still show "yellow" when the path finishes and your mouse is hovering on a blocked tile.

mouse_wall_issue

If the current behavior is a bug, please provide the exact steps to reproduce.

Make sure that your mouse will land on a blocked tile when player is finished walking.

  1. Right-click on a walkable tile
  2. Click on 'Walk here'

What is the expected behavior?

For the mouse selection to turn red and thus not click be attempt to walk there.
@naknode naknode added bug "Hey, that's not suppose to happen." canvas (Graphic) issues on the game canvas. easy Issue/feature that is easy to fix or implement. Good for 1st-time contributors. good first issue Easy issues that are excellent for people wanting to get in meat of the code. low priority Nice-to-have issues and features. labels Jan 5, 2018
@naknode naknode added this to the v0.0.1 milestone Jan 5, 2018
@naknode
Copy link
Member Author

naknode commented Jan 6, 2018

Note: this bug is likely not to be reproduced many times. As soon as you move your mouse at least ONE pixel after you click, then the issue will be fixed.

But, still, it's still nice to have this fixed.

@maxrumsey
Copy link
Contributor

I can reproduce, assign me to the question, please!

@naknode
Copy link
Member Author

naknode commented Feb 22, 2018

@dathappysheep You can fork at any time and send in a PR :-)

@naknode
Copy link
Member Author

naknode commented Aug 18, 2018

@maxrumsey I cannot assign this issue to you if you are not a member of this organization.

naknode pushed a commit that referenced this issue Dec 14, 2018
Tidying up some things for #8
425185b
aleks-rope pushed a commit to aleks-rope/game that referenced this issue May 8, 2020
Greenkeeper/tailwindcss 0.6.6 (delaford#8)
e949d1d 
* chore(package): update tailwindcss to version 0.6.6

* chore(package): update lockfile yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug "Hey, that's not suppose to happen." canvas (Graphic) issues on the game canvas. easy Issue/feature that is easy to fix or implement. Good for 1st-time contributors. good first issue Easy issues that are excellent for people wanting to get in meat of the code. low priority Nice-to-have issues and features.
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@naknode @maxrumsey