Add tests for bespin.amazon.credentials #44
Conversation
|
Oh python2.6. You so silly. |
tests/amazon/test_credentials.py
Outdated
| @@ -33,8 +33,7 @@ | |||
| @mock_sts | |||
| it "verify_creds ensures account_id matches aws": | |||
| credentials = Credentials('us-west-1', 987654321, NotSpecified) | |||
| with self.assertRaises(BespinError): | |||
| credentials.verify_creds() # 987654321 != 123456789012 | |||
| self.assertRaises(BespinError, credentials.verify_creds) # 987654321 != 123456789012 | |||
There was a problem hiding this comment.
I suggest
with self.fuzzAssertRaisesError(BespinError, "message you expect", kwarg1=1, kwarg2=2):
credentials.verify_creds()
It's defined by delfick_error (https://github.com/delfick/delfick_error/blob/master/delfick_error.py#L143)
There was a problem hiding this comment.
Travis didn't like that.
There was a problem hiding this comment.
I can't see delfick_error in setup.py
tests/amazon/test_credentials.py
Outdated
| from bespin.amazon.credentials import Credentials | ||
| from bespin.errors import BespinError | ||
| from tests.helpers import BespinCase | ||
| from input_algorithms.spec_base import NotSpecified |
There was a problem hiding this comment.
I'm a bit nitpicky about imports
Usually I split into groups
<bespin imports>
<test specific imports>
<other imports>
Each block has no empty newlines and is ordered by the length of the line, longest line to shortest line.
so here, would be
from bespin.amazon.credentials import Credentials
from bespin.errors import BespinError
from tests.helpers import BespinCase
from input_algorithms.spec_base import NotSpecified
from moto import mock_sts
import os
tests/amazon/test_credentials.py
Outdated
| @mock_sts | ||
| it "verify_creds ensures account_id matches aws": | ||
| credentials = Credentials('us-west-1', 987654321, NotSpecified) | ||
| with self.fuzzAssertRaisesError(BespinError, "Please use credentials for the right account", expect=self.account_id, got=amazon_account_id): |
atward
force-pushed
the
moto_creds
branch
2 times, most recently
from
9b35c6c
to
12b90c0
Compare
|
Would it be better/possible to mock a clone of os.environ for the particular unittests which would modify the environment? |
|
possibly, should be possible with mock.patch.dict https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch.dict |
|
unittest.mock is only available post python 3.3 |
|
that's why it's a dep in setup.py https://github.com/delfick/bespin/blob/master/setup.py#L37 |
No description provided.