-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the new SKY firmware effect available on LIFX Ceiling devices #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me :)
Upstream have fixed the protocol specification so this is ready for review/merge. |
@Djelibeybi are you able to clean up the commit history a little please ? :) |
bf8ad5a
to
14af871
Compare
I haven't squashed any of the commits, but I have cleaned up the commit messages. Hope that's what you meant. ;) |
@Djelibeybi as in it feels this PR only really needs three commits
|
Signed-off-by: Avi Miller <me@dje.li>
Signed-off-by: Avi Miller <me@dje.li>
Signed-off-by: Avi Miller <me@dje.li>
14af871
to
2386719
Compare
Done. I also switched the field names to snake case to match everything else and updated the help text just a little bit. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks, do you want me to make a release too?
Not super urgent, but getting Interactor support would be nifty. I'm not sure if that's automagic these days or not. |
not overly. Technically interactor only has a lower bound on photons, but the docker container needs to be rebuilt for home assistant Anyway I have released new photons core and interactor and the docker builds here https://github.com/delfick/photons/actions/runs/9512926226 |
I'll add a reminder to take the container for a spin over the weekend. I've spent enough time staring at a screen today. :) |
Note that theTileEffectSkyType
enum is currently missing from the published protocol and needs to be added manually until LIFX add it themselves.The
TileEffectSkyType
enum has been added upstream.Signed-off-by: Avi Miller me@dje.li