Merge similar translation strings and avoid using HTML tags in translation strings #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiy
changed the title
| @@ -87,7 +87,7 @@ function textareas( $entry, $permissions, $index = 0 ) { | |||
| $warning = each( $referenceable ); | |||
| ?> | |||
| <div class="warning secondary"> | |||
| <?php printf( __( '<strong>Warning:</strong> %s', 'glotpress' ), esc_html( $warning['value'] ) ); ?> | |||
| <strong><?php _e( 'Warning:', 'glotpress' ); ?></strong> <?php esc_html_e( $warning['value'] ); ?> | |||
There was a problem hiding this comment.
esc_html_e() is used incorrect, should be echo esc_html().
|
@ocean90, thanks for the feedback. |
|
Hi @ramiy , as part of our move to the new repo this PR was closed when we merged back to "master" from "wordpress-dbi-plugin". If you still want to get it merged, just create a new PR to the "master" branch of the GlotPress/GlotPress-WP repo. Thanks and sorry of the inconvenience. |
|
Thank @ramiy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my trac tickets:
https://glotpress.trac.wordpress.org/ticket/504
https://glotpress.trac.wordpress.org/ticket/505
See the screenshot (and attached patch).
We are merging similar strings with different variations and avoid using HTML
<code>tags in translation strings.