This repository has been archived by the owner on Jun 26, 2021. It is now read-only.
Dataset refactoring #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -771,10 +648,10 @@ def __getitem__(self, index): | |||
|
|
|||
| data = self.data[index] | |||
| data_dict = {"data": np.array(data[0]), | |||
| "label": data[1].numpy().reshape(1).astype(np.float32)} | |||
| "label": data[1].reshape(1).astype(np.float32)} | |||
There was a problem hiding this comment.
Just to remember: This will fail with torchvision < 0.2.2; fixed in #66
justusschock
suggested changes
Apr 17, 2019
There was a problem hiding this comment.
Looks good in general, I left a few comments, but nothing major, except the _DatasetIterator from #83 is still missing
deprecation warning.
justusschock
approved these changes
Apr 24, 2019
This was referenced Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are there any additional functions which should be added or changes?