Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUB-52: Remove grpc #57

Merged
merged 2 commits into from Aug 23, 2021
Merged

PUB-52: Remove grpc #57

merged 2 commits into from Aug 23, 2021

Conversation

rohit-gohri
Copy link
Member

@rohit-gohri rohit-gohri commented Aug 20, 2021 •
edited

Remove PUBSUB_USE_GRPC options and dependency

@rohit-gohri rohit-gohri added this to the v2 milestone Aug 20, 2021
@rohit-gohri rohit-gohri changed the title PUB-52: remove grpc PUB-52: Remove grpc Aug 20, 2021
@ishan123456789
Copy link
Contributor

We might want to log an error in this case stating

PUBSUB_USE_GRPC=true has been deprecated use v1.x to use GRPC
Rest LGTM

@rohit-gohri
Copy link
Member Author

We might want to log an error in this case stating

PUBSUB_USE_GRPC=true has been deprecated use v1.x to use GRPC

I don't think that's needed if we are doing a breaking release (V2)

@rohit-gohri rohit-gohri merged commit a0217ff into releases/v2 Aug 23, 2021
@rohit-gohri rohit-gohri deleted the chore/PUB-52-remove-grpc branch August 23, 2021 07:53
@rohit-gohri rohit-gohri mentioned this pull request Sep 21, 2021
Merged
10 tasks
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan123456789 ishan123456789 ishan123456789 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit-gohri @ishan123456789