Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUB-58 - Release v2 #71

Merged
merged 93 commits into from
Nov 9, 2021
Merged

PUB-58 - Release v2 #71

merged 93 commits into from
Nov 9, 2021

Conversation

rohit-gohri
Copy link
Member

@rohit-gohri rohit-gohri commented Sep 21, 2021 •
edited
Loading

@rohit-gohri rohit-gohri added this to the v2 milestone Sep 21, 2021
@rohit-gohri rohit-gohri self-assigned this Sep 21, 2021
rohit-gohri and others added 15 commits September 21, 2021 13:16
@rohit-gohri
Merge branch 'releases/v2' of https://github.com/deliveryhero/hfc-pubsub
265f681 
 into chore/PUB-65-dead-code-remove
@rohit-gohri
⚰️ remove v1/v2 test examples and use module name for imports
48d905c
@rohit-gohri
update examples
5b72402
@ishan123456789
Merge pull request #72 from deliveryhero/chore/PUB-68-engines
4b36feb 
PUB-68 - 💥 set min supported node version as 12.22
@rohit-gohri
✅ remove tests for deprecated code and refactor rest
54049d6
@rohit-gohri
⬆️ update dev deps
b18ae70
@rohit-gohri
🚨 remove any
507715e
@rohit-gohri
✅ increase test timeout
5acd7e9
@rohit-gohri
ignore tests in semgrep and change coverage targets
4045fa6
@rohit-gohri
Merge branch 'main' of https://github.com/deliveryhero/hfc-pubsub int…
b69436e 
…o chore/PUB-65-dead-code-remove
@rohit-gohri
reduce coverage threshold
f575cb0
@rohit-gohri
Merge branch 'main' of https://github.com/deliveryhero/hfc-pubsub int…
ab26535 
…o releases/v2
@rohit-gohri
Merge branch 'releases/v2' of https://github.com/deliveryhero/hfc-pubsub
c359442 
 into chore/PUB-65-dead-code-remove
@rohit-gohri
Merge pull request #66 from deliveryhero/chore/PUB-65-dead-code-remove
b829b8a 
PUB-65 : ⚰️ remove dead and deprecated code
@ishan123456789
Throws error in case no subs, wrong path
9407f38
@rohit-gohri rohit-gohri marked this pull request as ready for review November 9, 2021 07:09
@rohit-gohri
make project id optional in env var and allow setting it through GOOG…
571db01 
…LE_CLOUD_PROJECT too
@rohit-gohri
⚡️ cache projectNumber per project and load subscriptionService only …
c37a680 
…once
@rohit-gohri
don't create unnecessary extended classes
d9f43da
@rohit-gohri
pass metadata to global error handler
b673e13
@rohit-gohri
remove unnecessary exports
e66612f
@rohit-gohri
remove ackDeadlineSeconds
cd0f292
@rohit-gohri
use early return
7568fa0
@rohit-gohri
throw error if could not create subscription
b2cce20
@rohit-gohri
✅ fix tests
5a5c4a5
@rohit-gohri
docs(changeset): Change project id env var to GOOGLE_CLOUD_PROJECT, d…
5ec748a 
…on't export private methods, refactor internals, and remove ackDeadlineSeconds - PUB-77
@rohit-gohri
update migration guide
b551222
@rohit-gohri
ignore warning
e2f5d07
@rohit-gohri
fix build
8ded356
@rohit-gohri
remove GOOGLE_CLOUD_PUB_SUB_PROJECT_ID
d75a4db
@rohit-gohri
Merge pull request #84 from deliveryhero/PUB-77-misc
85a151f
@rohit-gohri
fix npmignore
4934b14
@ishan123456789 ishan123456789 merged commit e363c82 into main Nov 9, 2021
@ishan123456789 ishan123456789 deleted the releases/v2 branch November 9, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan123456789 ishan123456789 ishan123456789 approved these changes

Assignees

@rohit-gohri rohit-gohri

Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit-gohri @ishan123456789