Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUB-77 : Env var change, reduce api calls, and refactor internals #84

Merged
merged 14 commits into from Nov 9, 2021
Merged

PUB-77 : Env var change, reduce api calls, and refactor internals #84

merged 14 commits into from Nov 9, 2021

Conversation

rohit-gohri
Copy link
Member

@rohit-gohri rohit-gohri commented Nov 9, 2021 •
edited

Closes PUB-77

  • Change project id env var to GOOGLE_CLOUD_PROJECT
  • Cache project-number
  • Pass metadata to global error handler
  • Change subscriberTuple
  • Change ackDeadlineSeconds to ackDeadline

@rohit-gohri rohit-gohri mentioned this pull request Nov 9, 2021
Merged
10 tasks
@rohit-gohri rohit-gohri merged commit 85a151f into releases/v2 Nov 9, 2021
@rohit-gohri rohit-gohri deleted the PUB-77-misc branch November 9, 2021 09:44
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan123456789 ishan123456789 ishan123456789 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit-gohri @ishan123456789