Introduce specialized annotations for scoped injectors #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tanceBinding and AutoInjectorBinding respectively
…, activity, service, view)
… annotations are still internal, and there might still be valid use cases for when consumers just don't want/need to create a completely new annotation
kingsleyadio
force-pushed
the
task/dynamic-injector-bindings
branch
from
8c21951
to
05743b9
Compare
helios66
approved these changes
Sep 23, 2022
vivek-varun
approved these changes
Sep 26, 2022
This was referenced Sep 26, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use
ContributesInjectorfor all cases where we do field/method injection: application, activity, service and view scopesInstead, we want to have specialized annotations (similar to ContributesFragment, etc) for these entities
Convention:
ContributesXyz => constructor injection. E.g ContributesFragment
ContributesXyzInjector => field/method injection. E.g ContributesActivityInjector. This is to avoid any confusion about whether these entities support constructor injection
Concern
ContributesXyzInjectorcan be quite long. E.gContributesApplicationInjector. So I decided to shorten this specific one toContributesAppInjector. But I wonder if we can still find a better naming for them in generalFlexibility
This PR introduces a new AutoInjectorBinding meta-annotation, similar to the existing AutoScopedBinding (now renamed to AutoInstanceBinding). These annotations may be used outside of whetstone to mark user-land annotations so that they can be automatically processed by whetstone-compiler for either constructor (instance) or field/method (injector) injections. Note: this API is still marked as
InternalWhetstoneApifor now