Rdfg enhancements #84

rawstorage · 2020-02-10T13:21:25Z

Replication Enhancements

RDF functions added

-create_rdf_group
-modify_rdf_group
-delete_rdf_group
-get_rdf_port_connections
-get_rdf_director_port_details
-get_rdf_director_ports
-get_rdf_director
-get_rdf_director_list
-create_storage_group_from_rdfg

BugFix

update to rest_requests header parameter corrected to application-type line 54

Fix in CI_Test for effective_wwn functions and set initiator flags

…ype header incorrectly in lowercase. Added skip to 2 tests in provisioning ci_tests for external wwn.

…ing.

…on thanks to extra space with pluralisation. :(

…t test and ci_test + update to change log.

csv reader that are used in csv writer. Added skips to effective wwn tests where no effective wwn enabled volumes can be found.

test to prevent issues where the in-use initiator that was selected was in a group causing conflicts when attempting to set flags.

added create_storage_group_from_rdfg ci_test and unit test

…ancements

helenwalsh

A few style issues only. Also, just for future reference, perhaps we separate the issues into pull requests so for example application-type fix and initiator group tests fix get their own pull request. Just a suggestion.

helenwalsh · 2020-02-13T10:27:39Z

PyU4V/replication.py

@@ -11,7 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-"""replication.py."""
+'''replication.py.'''


Doc strings should be in double quotes

helenwalsh · 2020-02-13T10:28:42Z

PyU4V/replication.py



 class ReplicationFunctions(object):
-    """ReplicationFunctions."""
+    '''ReplicationFunctions.'''


Looks like they have been changed throughout the document. Please change them to ". Thanks

Thanks Helen that was a find replace error.

helenwalsh · 2020-02-13T10:29:43Z

PyU4V/replication.py

-        Optional boolean parameters to set are "bypass", "metroBias", "star",
-        "immediate", "hop2", "consExempt", "force", "symForce".
+        Optional boolean parameters to set are 'bypass', 'metroBias', 'star',
+        'immediate', 'hop2', 'consExempt', 'force', 'symForce'.


Just to avoid confusion. Having single quotes here is fine. It is also in the doc strings so less concerned with this anyway

I've changed back to original, this change was made in error

helenwalsh · 2020-02-13T10:30:40Z

PyU4V/replication.py

+
+        :param array_id: 12 digit serial number for PowerMax array -- str
+        :param director_id: identifier for director e.g. RF-1F -- str
+        :param filters: optional filters - dict


nit -- instead of -

helenwalsh · 2020-02-13T10:31:09Z

PyU4V/replication.py

+        :param array_id: 12 digit serial number for  PowerMax array -- str
+        :param director_id: identifier for director e.g. RF-1F -- str
+        :param port_id: port number -- int
+        :returns: port details --dict


nit - add a stace

helenwalsh · 2020-02-13T10:36:48Z

PyU4V/tests/ci_tests/base.py

+        remote_rdf_director_list = self.replication.get_rdf_director_list(
+            filters={'online': True})
+        for director in remote_rdf_director_list:
+            remote_rdf_director_port_list = \


brackets instead of \

helenwalsh · 2020-02-13T10:37:06Z

PyU4V/tests/ci_tests/base.py

+        """Helper function to get RDFG on arrays that is free for use
+
+        :returns: next RDF group number on local and remote array
+


remove empty line

done, found another like this

PyU4V/tests/ci_tests/test_pyu4v_ci_replication.py

helenwalsh · 2020-02-13T10:39:31Z

PyU4V/tests/unit_tests/pyu4v_common_data.py

@@ -11,11 +11,11 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-"""pyu4v_common_data.py."""
+'''pyu4v_common_data.py.'''


double quotes

MichaelMcAleer

I stopped reviewing this, too much to add in one review.

Fix the parameters, their ordering, and collapse all the multi-line stuff to as few lines as possible to save on space in the overall file, it helps out IDEs load inspections faster. There is also a lot of trailing ) or } which could be moved up a line or two to further save space.

After these are done ill go through the code for problems

PyU4V/replication.py

MichaelMcAleer · 2020-02-13T14:52:59Z

PyU4V/replication.py

+            resource_level=SYMMETRIX, resource_level_id=array_id,
+            resource_type=RDF_DIRECTOR, resource_type_id=director_id,
+            resource=PORT, params=filters
+        )


Nit: move the ) to the previous line instead of a line of its own

MichaelMcAleer · 2020-02-13T14:53:13Z

PyU4V/replication.py

+            resource_level=SYMMETRIX, resource_level_id=array_id,
+            resource_type=RDF_DIRECTOR, resource_type_id=director_id,
+            resource=PORT, resource_id=port_id
+        )


Nit: Move ) to previous line

PyU4V/replication.py

MichaelMcAleer · 2020-02-13T14:58:02Z

PyU4V/replication.py

+                "action": "set_label"
+            }
+
+        elif rdfg_action == 'add_ports' or 'remove_ports':


This wont work, second half of or statement will always evaluate to True because it is a populated string. Should be:

elif rdfg_action == 'add_ports' or rdfg_action == 'remove_ports':

A better implementation would be

elif rdfg_action in ['add_ports', 'remove_ports']:

changed will need to re-run ci to verify still working

MichaelMcAleer · 2020-02-13T14:58:30Z

PyU4V/replication.py

+                             resource_level_id=array_id,
+                             resource_type=RDF_GROUP,
+                             resource_type_id=srdf_group_number,
+                             payload=payload)


Collapse these into a few lines, save space where possible

MichaelMcAleer · 2020-02-13T14:58:56Z

PyU4V/replication.py

+                             resource_level_id=array_id,
+                             resource_type=RDF_GROUP,
+                             resource_type_id=srdf_group_number,
+                             )


Move ) to previous line, collapse params to as few lines as possible

done and collapsed

PyU4V/replication.py

… on Pull 84

csv reader that are used in csv writer. Added skips to effective wwn tests where no effective wwn enabled volumes can be found.

test to prevent issues where the in-use initiator that was selected was in a group causing conflicts when attempting to set flags.

… on Pull 84

MichaelMcAleer

More changes required there, nothing major its almost all formatting

PyU4V/replication.py

PyU4V/tests/unit_tests/test_pyu4v_replication.py

PyU4V/utils/file_handler.py

…take a look at

…ancements # Conflicts: # PyU4V/replication.py

MichaelMcAleer

Everything looks good Paul, once the CSVReader delimiter comment is addressed ill give it my +1

PyU4V/tests/ci_tests/test_pyu4v_ci_provisioning.py

be assigned by function parameters.

MichaelMcAleer

Approving, all requested changes made and CI has had 4 clean runs since most recent commit.

…rmatting for documentation

…ancements

…rmatting for documentation, one minor typo and additional content added to create_storage_group_from_rdf_group

…rmatting for documentation, one minor typo and additional content added to create_storage_group_from_rdf_group, configuration.rst -> line 152: arguements should be arguments reccomendations.rst -> line 13: it's should be its support.rst -> line 4: Github should be GitHub tools.rst -> lines 37, 41, 73: Github should be GitHub

Rdfg enhancements, documentation and change log updates

rawstorage and others added 9 commits February 6, 2020 11:57

added new functions for replication.py and bug file for application-t…

63cfa72

…ype header incorrectly in lowercase. Added skip to 2 tests in provisioning ci_tests for external wwn.

added new functions for replication.py and bug file for application-t…

9a70d5a

…ype header incorrectly in lowercase. Added skip to 2 tests in provisioning ci_tests for external wwn.

maded port detail port_details to be consistent with other module nam…

e41e452

…ing.

pep8 error line1123 replication, spotted after commit. Over indendati…

ab2d450

…on thanks to extra space with pluralisation. :(

added new function create_storage_group_from_rdfg with associated uni…

79a228d

…t test and ci_test + update to change log.

Added same delimiter and quotechar params to

88fedf0

csv reader that are used in csv writer. Added skips to effective wwn tests where no effective wwn enabled volumes can be found.

Added additional setup to test_modify_initiator_change_initiator_flags

8c95174

test to prevent issues where the in-use initiator that was selected was in a group causing conflicts when attempting to set flags.

updated unit_test for application-type header.

62061c1

added create_storage_group_from_rdfg ci_test and unit test

Merge remote-tracking branch 'origin/rdfg_enhancements' into rdfg_enh…

90394b6

…ancements

rawstorage requested review from MichaelMcAleer, helenwalsh and odonos12 and removed request for MichaelMcAleer February 13, 2020 10:36

helenwalsh suggested changes Feb 13, 2020

View reviewed changes

rawstorage added 3 commits February 13, 2020 14:15

corrected quotes in docstrings

00414b4

Changes per review on Pull 84

fa32f55

Changes per review on Pull 84

be5652b

MichaelMcAleer suggested changes Feb 13, 2020

View reviewed changes

Changes per review on Pull 84

00e76b3

MichaelMcAleer self-requested a review February 13, 2020 15:39

rawstorage and others added 8 commits February 13, 2020 16:00

Ordering of Parameters in new function doc strings Changes per review…

565b848

… on Pull 84

Added same delimiter and quotechar params to

9264685

csv reader that are used in csv writer. Added skips to effective wwn tests where no effective wwn enabled volumes can be found.

Added additional setup to test_modify_initiator_change_initiator_flags

6137586

test to prevent issues where the in-use initiator that was selected was in a group causing conflicts when attempting to set flags.

corrected quotes in docstrings

4ddc4ad

Changes per review on Pull 84

8c2a3d6

Changes per review on Pull 84

701ed09

Changes per review on Pull 84

8c53d99

Ordering of Parameters in new function doc strings Changes per review…

5d89744

… on Pull 84

MichaelMcAleer suggested changes Feb 14, 2020

View reviewed changes

Addressed comments from @michael McAleer. 2 Outstanding for Simon to …

d22884f

…take a look at

Merge remote-tracking branch 'origin/rdfg_enhancements' into rdfg_enh…

508b9fe

…ancements # Conflicts: # PyU4V/replication.py

MichaelMcAleer reviewed Feb 14, 2020

View reviewed changes

PyU4V/tests/ci_tests/test_pyu4v_ci_provisioning.py Show resolved Hide resolved

Change delimiter and quotechar in csv reader and writer to

8ffc4cf

be assigned by function parameters.

MichaelMcAleer self-requested a review February 17, 2020 11:18

MichaelMcAleer approved these changes Feb 17, 2020

View reviewed changes

rawstorage added 2 commits February 18, 2020 11:07

added docs for version 9.2, minor changes to docstrings to correct fo…

a92ae91

…rmatting for documentation

Merge remote-tracking branch 'origin/rdfg_enhancements' into rdfg_enh…

2834576

…ancements

helenwalsh approved these changes Feb 19, 2020

View reviewed changes

rawstorage added 2 commits February 19, 2020 10:58

added docs for version 9.2, minor changes to docstrings to correct fo…

3be0efd

…rmatting for documentation, one minor typo and additional content added to create_storage_group_from_rdf_group

rawstorage merged commit bc4751d into master Feb 19, 2020

rawstorage deleted the rdfg_enhancements branch February 19, 2020 19:06

rawstorage added a commit that referenced this pull request Aug 12, 2022

Merge pull request #84 from dell/rdfg_enhancements

7660e7d

Rdfg enhancements, documentation and change log updates

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rdfg enhancements #84

Rdfg enhancements #84

rawstorage commented Feb 10, 2020

helenwalsh left a comment

helenwalsh Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

helenwalsh Feb 13, 2020

rawstorage Feb 13, 2020

MichaelMcAleer left a comment

MichaelMcAleer Feb 13, 2020

rawstorage Feb 13, 2020

MichaelMcAleer Feb 13, 2020

rawstorage Feb 13, 2020

MichaelMcAleer Feb 13, 2020

rawstorage Feb 13, 2020

MichaelMcAleer Feb 13, 2020

rawstorage Feb 13, 2020

MichaelMcAleer Feb 13, 2020

rawstorage Feb 13, 2020

MichaelMcAleer left a comment

MichaelMcAleer left a comment

MichaelMcAleer left a comment

		"""Helper function to get RDFG on arrays that is free for use

		:returns: next RDF group number on local and remote array

Rdfg enhancements #84

Rdfg enhancements #84

Conversation

rawstorage commented Feb 10, 2020

Replication Enhancements

RDF functions added

BugFix

helenwalsh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichaelMcAleer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichaelMcAleer left a comment

Choose a reason for hiding this comment

MichaelMcAleer left a comment

Choose a reason for hiding this comment

MichaelMcAleer left a comment

Choose a reason for hiding this comment