[issue-1198] adding tests

dell · Jul 9, 2024 · 34c4b3d · 34c4b3d
1 parent 1891d5c
commit 34c4b3d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/pkg/node/node.go b/pkg/node/node.go
@@ -166,11 +166,6 @@ func (s *CSINodeService) processFakeAttachInNodeStageVolume(
 	if isFakeAttachNeeded {
 		if volumeCR.Annotations[fakeAttachVolumeAnnotation] != fakeAttachVolumeKey {
 			volumeCR.Annotations[fakeAttachVolumeAnnotation] = fakeAttachVolumeKey
-			if volumeCR.Spec.OperationalStatus == apiV1.OperationalStatusOperative {
-				if err := s.crHelper.UpdateVolumeOpStatus(ctx, volumeCR, apiV1.OperationalStatusMissing); err != nil {
-					ll.Errorf("unable to change volume operational status to MISSING with error: %v", err)
-				}
-			}
 			ll.Warningf("Adding fake-attach annotation to the volume with ID %s", volumeID)
 			if !isFakeAttachDR {
 				s.VolumeManager.recorder.Eventf(volumeCR, eventing.FakeAttachInvolved,
@@ -190,6 +185,9 @@ func (s *CSINodeService) processFakeAttachInNodeStageVolume(
 				return status.Error(codes.Internal, fmt.Sprintf("failed to mount device in stage volume: %s", err.Error()))
 			}
 		}
+		if volumeCR.Spec.OperationalStatus != apiV1.OperationalStatusMissing {
+			volumeCR.Spec.OperationalStatus = apiV1.OperationalStatusMissing
+		}
 	} else if volumeCR.Annotations[fakeAttachVolumeAnnotation] == fakeAttachVolumeKey {
 		delete(volumeCR.Annotations, fakeAttachVolumeAnnotation)
 		ll.Warningf("Removing fake-attach annotation for volume %s", volumeID)
@@ -401,6 +399,8 @@ func (s *CSINodeService) NodeStageVolume(ctx context.Context, req *csi.NodeStage
 			volumeCR.Annotations[wbtChangedVolumeAnnotation] = wbtChangedVolumeKey
 		}
 	}
+	ll.Errorf("raz dwa")
+	ll.Error(volumeCR)
 
 	if currStatus != apiV1.VolumeReady {
 		volumeCR.Spec.CSIStatus = newStatus

diff --git a/pkg/node/node_test.go b/pkg/node/node_test.go
@@ -971,6 +971,7 @@ var _ = Describe("CSINodeService Fake-Attach", func() {
 		err = node.k8sClient.ReadCR(testCtx, testV1ID, "", vol1)
 		Expect(err).To(BeNil())
 		Expect(vol1.Spec.CSIStatus).To(Equal(apiV1.VolumeReady))
+		Expect(vol1.Spec.OperationalStatus).To(Equal(apiV1.OperationalStatusMissing))
 		Expect(vol1.Annotations[fakeDeviceVolumeAnnotation]).To(Equal(newFakeDevice))
 	})
 	It("Should publish unhealthy fs-mode volume with fake-attach annotation", func() {