Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/configurable volume attributes #2

Closed
wants to merge 24 commits into from
Closed

Feature/configurable volume attributes #2

wants to merge 24 commits into from

Conversation

spriya-m
Copy link
Contributor

Description

K8s API code changes to get PVC labels

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#291

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Verified creation of volumes with and without labels, along with CSI driver

@spriya-m spriya-m requested a review from gilltaran as a code owner May 18, 2022 11:35
@spriya-m spriya-m closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@harshitap26 harshitap26 Awaiting requested review from harshitap26 harshitap26 is a code owner

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spriya-m @francis-nijay