Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix offline installer bug. #208

Merged
merged 1 commit into from Jun 20, 2023
Merged

fix offline installer bug. #208

merged 1 commit into from Jun 20, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 commented Jun 20, 2023 •
edited

Description

This pr addresses the bug in the offline bundle installation using csi-powerflex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#868

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the csi-powerflex driver using offline installer on both k8s and ocp the installation is successful
  • Ran cert-csi and it passed with 100%

gallacher
gallacher requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a reference to the GitHub issue associated with this PR. Thanks.

@VamsiSiddu-7 VamsiSiddu-7 merged commit fea900f into main Jun 20, 2023
4 checks passed
@gallacher gallacher deleted the bugfix/offline-bundle branch June 20, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher approved these changes

@khareRajshree khareRajshree khareRajshree approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@ashleyvjoy ashleyvjoy ashleyvjoy approved these changes

@KshitijaKakde KshitijaKakde KshitijaKakde approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@VamsiSiddu-7 @gallacher @khareRajshree @bharathsreekanth @ashleyvjoy @KshitijaKakde