Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding k8 1.26 support #156

Merged
merged 2 commits into from
Jan 12, 2023
Merged

adding k8 1.26 support #156

merged 2 commits into from
Jan 12, 2023

Conversation

boyamurthy
Copy link
Contributor

Adding k8 1.26 support

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#597

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

delldubey
delldubey previously approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delldubey delldubey self-requested a review January 12, 2023 10:04
delldubey
delldubey approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit c127b37 into main Jan 12, 2023
@shanmydell shanmydell deleted the feature_597_k8_1.26_support branch July 18, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@delldubey delldubey delldubey approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@mjsdell mjsdell Awaiting requested review from mjsdell

@nidtara nidtara Awaiting requested review from nidtara

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

@tssushma tssushma Awaiting requested review from tssushma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@boyamurthy @shanmydell @delldubey