Updated RBAC clusterrole fix #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryagupta4
requested review from
sakshi-garg1,
AkshaySainiDell,
adarsh-dell,
rishabhatdell and
alankar-verma
suryagupta4
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7,
tdawe,
shaynafinocchiaro,
atye and
sharmilarama
as code owners
adarsh-dell
approved these changes
Apr 27, 2023
|
@suryagupta4 , I have approved it. Please go ahead and merge it. |
adarsh-dell
added a commit
that referenced
this pull request
May 16, 2023
* Supporting resiliency module * Adding Driver & module combinations supported by CSM-operator * Changes to operatorconfig * adding role to the controller & node pods * Enhancing logs * modifying file read path * Adding few more samples for powerscale and powerflex * added volumemount paths & privileged capabilities * version v1.7.0 * Extracting driverType for picking right file * Code cleanup * UT first step * Resiliency module will be supported from v1.6.0 onwards for driver if installed by csm-operator * changed driver config version to v2.7.0 & resiliency to v1.6.0 * updated driver config params & min upgrade path for driver v2.7.0 config * Updated RBAC clusterrole fix (#211) * Resiliency-unit-test (#212) * Removing unnecessary extra lines * Logic to handle isilon as well as powerscale * Multi component for resiliency module (#218) * multi components for resiliency module * Resiliency module support for PowerScale driver (#219) * Resiliency support for PowerScale * Code cleanup * yaml fix * Permission for bidirectional mount * Code cleanup * Updated kubelet config dir (#221) * ModuleConfig Changes for Resiliency support for PowerFlex driver (#222) * feature/Resiliency_module_support_powerflex * Code cleanup (#226) * Remove VGS from PFlex config files (#220) * removed or commented out vg-snap * uncomment snapshotter * remove vgs from csv file * Update controller.yaml * Code cleanup * Merging main branch changes * Code optimization --------- Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> * Resolving review comment * Removed setting unnecessary ENV var with default value --------- Co-authored-by: suryagupta4 <Surya.Gupta1@dell.com> Co-authored-by: Surya Prakash Gupta <109594002+suryagupta4@users.noreply.github.com> Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
adarsh-dell
added a commit
that referenced
this pull request
May 23, 2023
* Supporting resiliency module * Adding Driver & module combinations supported by CSM-operator * Changes to operatorconfig * adding role to the controller & node pods * Enhancing logs * modifying file read path * Adding few more samples for powerscale and powerflex * added volumemount paths & privileged capabilities * version v1.7.0 * Extracting driverType for picking right file * Code cleanup * UT first step * Resiliency module will be supported from v1.6.0 onwards for driver if installed by csm-operator * changed driver config version to v2.7.0 & resiliency to v1.6.0 * updated driver config params & min upgrade path for driver v2.7.0 config * Updated RBAC clusterrole fix (#211) * Resiliency-unit-test (#212) * Resiliency-unit-test * Resiliency-unit-test * Resiliency-unit-test * Removing unnecessary extra lines * Logic to handle isilon as well as powerscale * Multi component for resiliency module (#218) * multi components for resiliency module * Resiliency module support for PowerScale driver (#219) * Resiliency support for PowerScale * Code cleanup * yaml fix * Permission for bidirectional mount * Code cleanup * Updated kubelet config dir (#221) * ModuleConfig Changes for Resiliency support for PowerFlex driver (#222) * feature/Resiliency_module_support_powerflex * feature/Resiliency_module_support_powerflex * Code cleanup (#226) * Remove VGS from PFlex config files (#220) * removed or commented out vg-snap * uncomment snapshotter * remove vgs from csv file * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Update controller.yaml * Code cleanup * Merging main branch changes * Code optimization --------- Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> * Resolving review comment * Removed setting unnecessary ENV var with default value * Podmon container reordering (#230) * Resiliency E2E Changes (#234) * resiliency e2e changes for powerstore * ResiliencySideCarName spelling correction * updated podmon sidecar check * added e2e tests for powerflex resiliency * updated yamls * E2E test for powerscale driver with resiliency module * update for custom test format & driver image version * fixed indentation * module set to true in storage_csm_powerscale_resiliency.yaml * renaming variable * Update storage_csm_powerflex.yaml * updated driver image to latest for e2e test files --------- Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com> Co-authored-by: Kumar Yadav <Adarsh.KumarYadav@dell.com> * Resiliency-unit-test-Updated (#240) * fixing typo in e2e values.yaml * Extending sample file for supporting resiliency module (#239) * Resiliency_module_node_and_sample_yaml_powerflex * Resiliency_module_node_and_sample_yaml_powerflex * Resiliency_module_node_and_sample_yaml_powerflex * Resiliency_module_node_and_sample_yaml_powerflex * adding replication module * Removing UT for 2.6.0 PowerStore Driver * UT coverage from 70% to 90+% * Addressing review comment * Addressing review comment * updated driver image to nightly in e2e test files * Updated custom tests in e2e --------- Co-authored-by: suryagupta4 <Surya.Gupta1@dell.com> Co-authored-by: Surya Prakash Gupta <109594002+suryagupta4@users.noreply.github.com> Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com> Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com> Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for fixing the RBAC clusterroles updating correctly for node & adding delete permission to volumeattachments required for resiliency module.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration