Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #226

Merged
merged 5 commits into from May 10, 2023
Merged

Code cleanup #226

merged 5 commits into from May 10, 2023

Conversation

adarsh-dell
Copy link
Contributor

Description

Code cleanup for resiliency module support feature.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#739

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

jooseppi-luna and others added 2 commits May 5, 2023 15:59
@jooseppi-luna
Remove VGS from PFlex config files (#220)
c393788 
* removed or commented out vg-snap

* uncomment snapshotter

* remove vgs from csv file

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml
@adarsh-dell
Code cleanup
ec4c983
@adarsh-dell adarsh-dell merged commit a4f33b2 into feature/resiliency_module May 10, 2023
adarsh-dell added a commit that referenced this pull request May 16, 2023
@adarsh-dell @suryagupta4
@sakshi-garg1 @jooseppi-luna
Feature/resiliency module (#227)
72b10ac 
* Supporting resiliency module

* Adding Driver & module combinations supported by CSM-operator

* Changes to operatorconfig

* adding role to the controller & node pods

* Enhancing logs

* modifying file read path

* Adding few more samples for powerscale and powerflex

* added volumemount paths & privileged capabilities

* version v1.7.0

* Extracting driverType for picking right file

* Code cleanup

* UT first step

* Resiliency module will be supported from v1.6.0 onwards for driver if installed by csm-operator

* changed driver config version to v2.7.0 & resiliency to v1.6.0

* updated driver config params & min upgrade path for driver v2.7.0 config

* Updated RBAC clusterrole fix (#211)

* Resiliency-unit-test (#212)

* Removing unnecessary extra lines

* Logic to handle isilon as well as powerscale

* Multi component for resiliency module (#218)

* multi components for resiliency module

* Resiliency module support for PowerScale driver (#219)

* Resiliency support for PowerScale

* Code cleanup

* yaml fix

* Permission for bidirectional mount

* Code cleanup

* Updated kubelet config dir (#221)

* ModuleConfig Changes for Resiliency support for PowerFlex driver (#222)

* feature/Resiliency_module_support_powerflex

* Code cleanup (#226)

* Remove VGS from PFlex config files (#220)

* removed or commented out vg-snap

* uncomment snapshotter

* remove vgs from csv file

* Update controller.yaml

* Code cleanup

* Merging main branch changes

* Code optimization

---------

Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>

* Resolving review comment

* Removed setting unnecessary ENV var with default value

---------

Co-authored-by: suryagupta4 <Surya.Gupta1@dell.com>
Co-authored-by: Surya Prakash Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
adarsh-dell added a commit that referenced this pull request May 23, 2023
@adarsh-dell @suryagupta4
@sakshi-garg1 @jooseppi-luna @rishabhatdell
Feature/resiliency module (#246)
85c663f 
* Supporting resiliency module

* Adding Driver & module combinations supported by CSM-operator

* Changes to operatorconfig

* adding role to the controller & node pods

* Enhancing logs

* modifying file read path

* Adding few more samples for powerscale and powerflex

* added volumemount paths & privileged capabilities

* version v1.7.0

* Extracting driverType for picking right file

* Code cleanup

* UT first step

* Resiliency module will be supported from v1.6.0 onwards for driver if installed by csm-operator

* changed driver config version to v2.7.0 & resiliency to v1.6.0

* updated driver config params & min upgrade path for driver v2.7.0 config

* Updated RBAC clusterrole fix (#211)

* Resiliency-unit-test (#212)

* Resiliency-unit-test

* Resiliency-unit-test

* Resiliency-unit-test

* Removing unnecessary extra lines

* Logic to handle isilon as well as powerscale

* Multi component for resiliency module (#218)

* multi components for resiliency module

* Resiliency module support for PowerScale driver (#219)

* Resiliency support for PowerScale

* Code cleanup

* yaml fix

* Permission for bidirectional mount

* Code cleanup

* Updated kubelet config dir (#221)

* ModuleConfig Changes for Resiliency support for PowerFlex driver (#222)

* feature/Resiliency_module_support_powerflex

* feature/Resiliency_module_support_powerflex

* Code cleanup (#226)

* Remove VGS from PFlex config files (#220)

* removed or commented out vg-snap

* uncomment snapshotter

* remove vgs from csv file

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Update controller.yaml

* Code cleanup

* Merging main branch changes

* Code optimization

---------

Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>

* Resolving review comment

* Removed setting unnecessary ENV var with default value

* Podmon container reordering (#230)

* Resiliency E2E Changes (#234)

* resiliency e2e changes for powerstore

* ResiliencySideCarName spelling correction

* updated podmon sidecar check

* added e2e tests for powerflex resiliency

* updated yamls

* E2E test for powerscale driver with resiliency module

* update for custom test format & driver image version

* fixed indentation

* module set to true in storage_csm_powerscale_resiliency.yaml

* renaming variable

* Update storage_csm_powerflex.yaml

* updated driver image to latest for e2e test files

---------

Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>
Co-authored-by: Kumar Yadav <Adarsh.KumarYadav@dell.com>

* Resiliency-unit-test-Updated (#240)

* fixing typo in e2e values.yaml

* Extending sample file for supporting resiliency module (#239)

* Resiliency_module_node_and_sample_yaml_powerflex

* Resiliency_module_node_and_sample_yaml_powerflex

* Resiliency_module_node_and_sample_yaml_powerflex

* Resiliency_module_node_and_sample_yaml_powerflex

* adding replication module

* Removing UT for 2.6.0 PowerStore Driver

* UT coverage from 70% to 90+%

* Addressing review comment

* Addressing review comment

* updated driver image to nightly in e2e test files

* Updated custom tests in e2e

---------

Co-authored-by: suryagupta4 <Surya.Gupta1@dell.com>
Co-authored-by: Surya Prakash Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: sakshi-garg1 <74704849+sakshi-garg1@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>
@rensyct rensyct deleted the codeCleanUp branch July 17, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell

@alikdell alikdell Awaiting requested review from alikdell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@coulof coulof Awaiting requested review from coulof

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher

@JacobGros JacobGros Awaiting requested review from JacobGros

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@karthikk92 karthikk92 Awaiting requested review from karthikk92

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa

@bandak2 bandak2 Awaiting requested review from bandak2

@mjsdell mjsdell Awaiting requested review from mjsdell

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rensyct rensyct Awaiting requested review from rensyct

@panigs7 panigs7 Awaiting requested review from panigs7

@tdawe tdawe Awaiting requested review from tdawe

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@atye atye Awaiting requested review from atye

@sharmilarama sharmilarama Awaiting requested review from sharmilarama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@adarsh-dell @AkshaySainiDell @suryagupta4 @jooseppi-luna