Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerFlex: Added env for kube node name #426

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Dec 22, 2023

Description

This PR includes addition of env X_CSI_POWERFLEX_KUBE_NODE_NAME that is required in the PowerFlex driver to fetch the node labels.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1086

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested the changes by installing the driver. The pods were up and running and the node labels were getting fetched correctly.

@suryagupta4 suryagupta4 merged commit 5793115 into main Jan 18, 2024
7 of 8 checks passed
rishabhatdell added a commit that referenced this pull request Jan 30, 2024
@rishabhatdell rishabhatdell mentioned this pull request Jan 30, 2024
10 tasks
adarsh-dell pushed a commit that referenced this pull request Jan 30, 2024
JacobGros added a commit that referenced this pull request Feb 19, 2024
* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <J.Grosner@emc.com>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <J.Grosner@emc.com>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <J.Grosner@emc.com>

---------

Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: grosnj1 <J.Grosner@emc.com>
@JacobGros JacobGros mentioned this pull request Feb 19, 2024
10 tasks
JacobGros added a commit that referenced this pull request Feb 20, 2024
* Verified merge fixed release v1.4.2 (#479)

* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <J.Grosner@emc.com>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <J.Grosner@emc.com>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <J.Grosner@emc.com>

---------

Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: grosnj1 <J.Grosner@emc.com>

* PR feedback

---------

Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: grosnj1 <J.Grosner@emc.com>
@JacobGros JacobGros mentioned this pull request Feb 20, 2024
10 tasks
JacobGros added a commit that referenced this pull request Feb 20, 2024
* Test branch (#482)

* Verified merge fixed release v1.4.2 (#479)

* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <J.Grosner@emc.com>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <J.Grosner@emc.com>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <J.Grosner@emc.com>

---------

Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: grosnj1 <J.Grosner@emc.com>

* PR feedback

---------

Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: grosnj1 <J.Grosner@emc.com>

* add KUBE_NODE_NAME back in

* add KUBE_NODE_NAME back in

* add KUBE_NODE_NAME back into tests

* Update dell-csm-operator.clusterserviceversion.yaml

---------

Co-authored-by: Don Khan <don.khan@dell.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
Co-authored-by: HarishH-DELL <harish.h2@dell.com>
Co-authored-by: panigs7 <spandita.panigrahi@dell.com>
Co-authored-by: Shayna Finocchiaro <shayna_finocchiaro@dell.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: panigs7 <92028646+panigs7@users.noreply.github.com>
Co-authored-by: abhi16394 <32352976+abhi16394@users.noreply.github.com>
Co-authored-by: Chiman Jain <36687396+chimanjain@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: grosnj1 <J.Grosner@emc.com>
@suryagupta4 suryagupta4 deleted the node-labels-pflex branch April 26, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants