Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar version update #131

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Sidecar version update #131

merged 1 commit into from
Mar 1, 2023

Conversation

satyakonduri
Copy link
Contributor

@satyakonduri satyakonduri commented Feb 21, 2023 •
edited
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Fresh Install
  • Upgrade Test

@satyakonduri satyakonduri self-assigned this Feb 21, 2023
nitesh3108
nitesh3108 reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@nitesh3108 nitesh3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT is failing, pls check

@satyakonduri satyakonduri force-pushed the sidecar-version-update branch 3 times, most recently from 41e4491 to e8e104d Compare February 22, 2023 06:55
@satyakonduri
Update Sidecar versions
22e044a 
Remove 2.3 support

Update csv

Update csv

Fix unit tests for Powerflex

Fix unit tests for Powerflex

Fix unit tests for Powerstore
@satyakonduri
Copy link
Contributor Author

UT is failing, pls check
Addressed @nitesh3108
Thank You.!

@satyakonduri satyakonduri merged commit 2040d3e into main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy boyamurthy is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

Assignees

@satyakonduri satyakonduri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@satyakonduri @rensyct @rajendraindukuri @nitesh3108 @karthikk92