Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/prometheus/client_golang Package update #140

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

meggm
Copy link
Contributor

@meggm meggm commented Mar 8, 2023

Description

Updated the go package github.com/prometheus/client_golang from v1.11.0 -> v1.14.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
    make docker-build is successful
  • Test B

gilltaran
gilltaran previously approved these changes Mar 9, 2023
@rensyct
Copy link
Contributor

rensyct commented Mar 9, 2023

@meggm and @gilltaran , is it the right approach to change the versions of indirect dependencies

@meggm
Copy link
Contributor Author

meggm commented Mar 17, 2023

@meggm and @gilltaran , is it the right approach to change the versions of indirect dependencies

@rensyct , Those are the dependencies got updated via go mod tidy. I did go get of
"github.com/prometheus/client_golang" package and executed go mod tidy.

@gilltaran
Copy link
Contributor

@meggm and @gilltaran , is it the right approach to change the versions of indirect dependencies

@rensyct , Those are the dependencies got updated via go mod tidy. I did go get of "github.com/prometheus/client_golang" package and executed go mod tidy.

@rensyct It's fine since these indirect dependencies got updated while doing go get and go mod tidy of the impacted package alone and if it is not breaking any other thing in code.

@satyakonduri satyakonduri merged commit c1f265d into main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants