Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added csi-powermax 2.7 support #147

Merged
merged 1 commit into from
May 8, 2023
Merged

Added csi-powermax 2.7 support #147

merged 1 commit into from
May 8, 2023

Conversation

boyamurthy
Copy link
Contributor

  1. Added support for powermax 2.7 driver
  2. Added k8 1.27 support

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#743
dell/csm#761

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

installing operator
#################
image

driver instalallation
#################
image

snap tests from cert-csi
#####################
image

@shanmydell shanmydell self-requested a review May 8, 2023 06:46
shanmydell
shanmydell previously approved these changes May 8, 2023
View reviewed changes
@tssushma tssushma self-requested a review May 8, 2023 06:47
tssushma
tssushma previously approved these changes May 8, 2023
View reviewed changes
Copy link

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rensyct
rensyct reviewed May 8, 2023
View reviewed changes
driverconfig/config.yaml
@@ -8,13 +8,26 @@ supportedK8sVersions:
drivers:
- name: powermax
configVersions:
- configVersion: v2.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove 2.4 version related code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed 2.4 config version

@boyamurthy boyamurthy dismissed stale reviews from tssushma and shanmydell via 314c882 May 8, 2023 09:37
@boyamurthy boyamurthy force-pushed the feature_743_powermax_2.7_support branch from 314c882 to 317dfcc Compare May 8, 2023 09:39
@shanmydell shanmydell self-requested a review May 8, 2023 10:33
@shanmydell shanmydell merged commit e6a39cd into main May 8, 2023
@shanmydell shanmydell deleted the feature_743_powermax_2.7_support branch May 8, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@shanmydell shanmydell shanmydell approved these changes

@tssushma tssushma tssushma left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boyamurthy @rensyct @shanmydell @tssushma