Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package which installed in base image cause error. #47

Closed
alex-tu-cc opened this issue Oct 24, 2017 · 2 comments
Closed

update package which installed in base image cause error. #47

alex-tu-cc opened this issue Oct 24, 2017 · 2 comments

Comments

@alex-tu-cc
Copy link
Collaborator

the commit "f352bd" for #28 will break base image packages updating.

example:

  1. create a usb disk with ubuntu recovery iso content.
  2. collect newer mesa stuff from x-staging[1] and x-swat[2] and put them to /debs for update.
  • ex. one of the stuff is libdrm2_2.4.83-1~16.04.1_amd64.deb
  1. do recovery from usb disk
  2. an older libdrm2 has been installed in base image, so /var/lib/ubiquity/installed-packages exists libdrm2:amd64
  3. then it will treat "libdrm2" differ to "libdrm2:amd64" then get a failed result in the code of commit "f352bd".

Then the failure cause showing a red error grub menu in next usb recovery booting.

Should we filter out ":amd64" from comparing?

[1] https://launchpad.net/~canonical-x/+archive/ubuntu/x-staging
[2] https://launchpad.net/~ubuntu-x-swat/+archive/ubuntu/updates/+packages
alex-tu-cc pushed a commit to alex-tu-cc/dell-recovery that referenced this issue Oct 24, 2017
filter out ":amd64" string when comparing new installed packages name (…
491e149 
…dell#47)

because of some installed package have postfix ":amd64", it will
confuse the logic of commit "f352bd" for dell#28 and treat it as a failure.

Signed-off-by: Alex Tu <alex.tu@canonical.com>
@alex-tu-cc alex-tu-cc mentioned this issue Oct 24, 2017
Merged
alex-tu-cc pushed a commit to alex-tu-cc/dell-recovery that referenced this issue Oct 25, 2017
filter out ":amd64" string when comparing new installed packages name (…
1db2fe5 
…dell#47)

because of some installed package have postfix ":amd64", it will
confuse the logic of commit "f352bd" for dell#28 and treat it as a failure.

Signed-off-by: Alex Tu <alex.tu@canonical.com>
alex-tu-cc pushed a commit to alex-tu-cc/dell-recovery that referenced this issue Oct 26, 2017
counting on dpkg --print-architecture to filter out architecture post…
0a71b5b 
…fix from package name. (dell#47)

Signed-off-by: Alex Tu <alex.tu@canonical.com>

# Merge-Proposal:
# Bug:  which is polling by jenkins in launchpad MP to comment related bugs.
# for commit message in launchpad: https://goo.gl/V9ePxQ
# (LP: #xxxxxxx)
alex-tu-cc pushed a commit to alex-tu-cc/dell-recovery that referenced this issue Oct 26, 2017
counting on dpkg --print-architecture to filter out architecture post…
8764f22 
…fix from package name. (dell#47)

Signed-off-by: Alex Tu <alex.tu@canonical.com>
alex-tu-cc pushed a commit to alex-tu-cc/dell-recovery that referenced this issue Oct 27, 2017
counting on dpkg --print-architecture to filter out architecture post…
1939729 
…fix from package name. (dell#47)

Signed-off-by: Alex Tu <alex.tu@canonical.com>
@fourdollars
Copy link
Collaborator

Could we just revert the commit "f352bd"?
We don't have much time to debug and fix the regression from it.

@alex-tu-cc alex-tu-cc mentioned this issue Oct 27, 2017
Closed
superm1 pushed a commit that referenced this issue Oct 27, 2017
@superm1
filter out ":amd64" string when comparing new installed packages name (…
956347a 
…#47)

because of some installed package have postfix ":amd64", it will
confuse the logic of commit "f352bd" for #28 and treat it as a failure.

Signed-off-by: Alex Tu <alex.tu@canonical.com>
superm1 pushed a commit that referenced this issue Oct 27, 2017
@superm1
counting on dpkg --print-architecture to filter out architecture post…
abc5d77 
…fix from package name. (#47)

Signed-off-by: Alex Tu <alex.tu@canonical.com>
@superm1
Copy link
Contributor

superm1 commented Oct 27, 2017

Pulled in the fix here.

@superm1 superm1 closed this as completed Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fourdollars @superm1 @alex-tu-cc