Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out ":amd64" string when comparing new installed packages name… #48

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

alex-tu-cc
Copy link
Collaborator

… (#47)

because of some installed package have postfix ":amd64", it will
confuse the logic of commit "f352bd" for #28 and treat it as a failure.

Signed-off-by: Alex Tu alex.tu@canonical.com

@superm1
Copy link
Contributor

superm1 commented Oct 24, 2017

Thanks for finding this. I think it would be be better to be architecture independent if possible (same problem could technically happen for i386 or any other architecture). Perhaps can you query the following to build the list?

# dpkg --print-architecture
# dpkg --print-foreign-architectures

I think that would be more future proof. Otherwise this looks good to me.

…dell#47)

because of some installed package have postfix ":amd64", it will
confuse the logic of commit "f352bd" for dell#28 and treat it as a failure.

Signed-off-by: Alex Tu <alex.tu@canonical.com>
@alex-tu-cc
Copy link
Collaborator Author

Thanks for superm1's suggestion, and uploaded a new commit 8764f,
so now it could be used on each architecture.

@fourdollars
Copy link
Collaborator

I have verified these commits but they didn't really fix the issue.

@superm1
Copy link
Contributor

superm1 commented Oct 26, 2017

Looks good, but if it doesn't fix the issue, what else is needed? I guess i'll hold off to merge until you guys say it's good.

…fix from package name. (dell#47)

Signed-off-by: Alex Tu <alex.tu@canonical.com>
@alex-tu-cc
Copy link
Collaborator Author

alex-tu-cc commented Oct 27, 2017

the issue was happen to 2nd commit for supporting other architecture than amd64, it caused by single quote which will treat $(dpkg --print-architecture) as string.

I force pushed the modification to 193972905e1e6f7d74778fd47a6e4b27f6483d16 to use double quote instead. It works fine on my machine now :)

@superm1 superm1 merged commit abc5d77 into dell:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants