Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ome_inventory]: code to fetch paginated data for devices groups and sub groups #575

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

sachin-apa
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#547

ISSUE TYPE

  • Bugfix Pull Request
COMPONENT NAME

ome_inventpry

OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@sachin-apa sachin-apa self-assigned this Nov 2, 2023
@sachin-apa sachin-apa linked an issue Nov 2, 2023 that may be closed by this pull request
@sachin-apa sachin-apa changed the title added a code to fetch paginated data [ome_inventory]: added a code to fetch paginated data for devices groups and sub groups Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e45988) 82.14% compared to head (c8d2e51) 82.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##           collections     #575   +/-   ##
============================================
  Coverage        82.14%   82.14%           
============================================
  Files              191      191           
  Lines            30195    30195           
  Branches          4768     4768           
============================================
  Hits             24805    24805           
  Misses            4638     4638           
  Partials           752      752           
Flag Coverage Δ
units 82.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachin-apa sachin-apa changed the title [ome_inventory]: added a code to fetch paginated data for devices groups and sub groups [ome_inventory]: code to fetch paginated data for devices groups and sub groups Nov 3, 2023
@sachin-apa
Copy link
Collaborator Author

run e2e

@sachin-apa sachin-apa added the validation/in-progress Validation is in progress label Nov 3, 2023
@sachin-apa sachin-apa added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Nov 14, 2023
@sachin-apa sachin-apa merged commit 876a20d into dell:collections Nov 15, 2023
26 checks passed
@sachin-apa sachin-apa deleted the bugs/ome_inventory_798 branch December 1, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
Development

Successfully merging this pull request may close these issues.

inventory plugin is only resturning 50 results per group
5 participants