-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.3.0: Sonar Fix #667
Merged
Kritika-Bhateja-03
merged 11 commits into
dell:collections
from
ABHISHEK-SINHA10:9.3.0/sonar_fix
May 23, 2024
Merged
9.3.0: Sonar Fix #667
Kritika-Bhateja-03
merged 11 commits into
dell:collections
from
ABHISHEK-SINHA10:9.3.0/sonar_fix
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABHISHEK-SINHA10
requested review from
sachin-apa,
felixs88,
Kritika-Bhateja-03,
rajshekarp87,
ShivamSh3 and
singh-lovepreet1
as code owners
May 22, 2024 10:23
Can one of the admins verify this patch? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## collections #667 +/- ##
===============================================
- Coverage 93.48% 91.39% -2.10%
===============================================
Files 201 203 +2
Lines 34500 34707 +207
Branches 5251 5297 +46
===============================================
- Hits 32253 31721 -532
- Misses 1345 1355 +10
- Partials 902 1631 +729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rajshekarp87
approved these changes
May 23, 2024
Kritika-Bhateja-03
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
ISSUE TYPE
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION
Checklist: