Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Molecule - idrac_storage_controller #671

Open
wants to merge 3 commits into
base: collections
Choose a base branch
from
Open

Molecule - idrac_storage_controller #671

wants to merge 3 commits into from

Conversation

singh-lovepreet1
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@singh-lovepreet1
Molecule- idrac_storage_controller
1ffff4e 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@singh-lovepreet1
Updated raid_nonraid and online_offline test cases
eb854da 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1
pdated ansible-lint-ignore file
05179de 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@rajshekarp87 rajshekarp87 added this to In progress in OpenManage Ansible Collection via automation Jun 5, 2024
@rajshekarp87 rajshekarp87 added the validation/in-progress Validation is in progress label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-apa sachin-apa Awaiting requested review from sachin-apa sachin-apa is a code owner

@felixs88 felixs88 Awaiting requested review from felixs88

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 Awaiting requested review from ABHISHEK-SINHA10 ABHISHEK-SINHA10 is a code owner

@Kritika-Bhateja-03 Kritika-Bhateja-03 Awaiting requested review from Kritika-Bhateja-03

@rajshekarp87 rajshekarp87 Awaiting requested review from rajshekarp87 rajshekarp87 is a code owner

@ShivamSh3 ShivamSh3 Awaiting requested review from ShivamSh3

At least 2 approving reviews are required to merge this pull request.

Assignees

@singh-lovepreet1 singh-lovepreet1

Labels
validation/in-progress Validation is in progress
Projects
OpenManage Ansible Collection
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@singh-lovepreet1 @ansible-collections-svc @rajshekarp87