Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idrac_reset] - Fixing issue #652 #675

Merged
merged 15 commits into from
Jun 18, 2024

Conversation

ABHISHEK-SINHA10
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.46%. Comparing base (43e633b) to head (3b3933f).

Files Patch % Lines
tests/unit/plugins/modules/test_idrac_reset.py 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           collections     #675   +/-   ##
============================================
  Coverage        93.46%   93.46%           
============================================
  Files              203      203           
  Lines            34702    34728   +26     
  Branches          5298     5302    +4     
============================================
+ Hits             32434    32460   +26     
  Misses            1356     1356           
  Partials           912      912           
Flag Coverage Δ
units 93.46% <96.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 marked this pull request as ready for review June 4, 2024 10:49
rajshekarp87
rajshekarp87 previously approved these changes Jun 5, 2024
@rajshekarp87 rajshekarp87 added the validation/in-progress Validation is in progress label Jun 5, 2024
@rajshekarp87 rajshekarp87 added this to In progress in OpenManage Ansible Collection via automation Jun 5, 2024
@ABHISHEK-SINHA10
Copy link
Collaborator Author

image

UT Coverage

@rajshekarp87 rajshekarp87 changed the title [9.4.0] - Fixing issue #652 [9.4.0] - idrac_reset - Fixing issue #652 Jun 11, 2024
@singh-lovepreet1
Copy link
Collaborator

Can we also update 'retVal' in the output to 'retval' that is being specified in the specs?

@singh-lovepreet1
Copy link
Collaborator

Can we also update existing examples according to the discussion?

@sachin-apa
Copy link
Collaborator

run e2e

@rajshekarp87 rajshekarp87 changed the title [9.4.0] - idrac_reset - Fixing issue #652 [idrac_reset] - Fixing issue #652 Jun 12, 2024
@singh-lovepreet1 singh-lovepreet1 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Jun 18, 2024
@rajshekarp87 rajshekarp87 merged commit 8643875 into dell:collections Jun 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
Development

Successfully merging this pull request may close these issues.

[BUG]: idrac_reset fails when idrac is InUse state [QUESTION]: Factory Reset iDRAC & wait_for_idrac?
8 participants