Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration Test] - idrac_reset #683

Merged
merged 11 commits into from
Jun 19, 2024
Merged

[Integration Test] - idrac_reset #683

merged 11 commits into from
Jun 19, 2024

Conversation

singh-lovepreet1
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@singh-lovepreet1
Added integration/idrac_reset
042d907 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1 singh-lovepreet1 changed the title Added integration/idrac_reset [Integration Test] - idrac_reset Jun 15, 2024
@singh-lovepreet1 singh-lovepreet1 self-assigned this Jun 15, 2024
@singh-lovepreet1 singh-lovepreet1 added the validation/in-progress Validation is in progress label Jun 15, 2024
@singh-lovepreet1 singh-lovepreet1 added this to the v9.4.0 milestone Jun 15, 2024
@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@singh-lovepreet1
Minor update
6315fca 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@rajshekarp87 rajshekarp87 added this to In progress in OpenManage Ansible Collection via automation Jun 17, 2024
@singh-lovepreet1
Fixed sonar issues
c556d19 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1
Sonar and lint issues fixed
03af548 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1
Addressed review comments
8c61964 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1
Updated doc
3f197a5 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1 singh-lovepreet1 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Jun 18, 2024
@singh-lovepreet1
Updated file extensions and renamed wait_for_idrac
2a74008 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@rajshekarp87
Copy link
Collaborator

Remove this file.

roles/prepare_idrac_lifecycle_controller_status/tasks/main.yaml

singh-lovepreet1 and others added 4 commits June 19, 2024 07:06
@singh-lovepreet1
Removed prepare_lifecycle_controller_status
5c08d58 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1
Addressed review comments
3788fa5 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@singh-lovepreet1
Merge branch 'collections' into feature/integration_idrac_reset
64f6065
@singh-lovepreet1
Addressed review comments
dbb1fd8 
Signed-off-by: Lovepreet Singh <Lovepreet.Singh1@dell.com>
@rajshekarp87 rajshekarp87 merged commit a63719a into dell:collections Jun 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajshekarp87 rajshekarp87 rajshekarp87 approved these changes

@sachin-apa sachin-apa sachin-apa approved these changes

@ShivamSh3 ShivamSh3 ShivamSh3 approved these changes

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 Awaiting requested review from ABHISHEK-SINHA10 ABHISHEK-SINHA10 is a code owner

@jagadeeshnv jagadeeshnv Awaiting requested review from jagadeeshnv

@Kritika-Bhateja-03 Kritika-Bhateja-03 Awaiting requested review from Kritika-Bhateja-03

Assignees

@singh-lovepreet1 singh-lovepreet1

Labels
validation/completed Validation is completed
Projects
OpenManage Ansible Collection
In progress
Milestone
v9.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@singh-lovepreet1 @ansible-collections-svc @rajshekarp87 @sachin-apa @Kritika-Bhateja-03 @ShivamSh3