Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/csi-powerflex] Added env for kube node name #347

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Dec 22, 2023

Is this a new chart?

No

What this PR does / why we need it:

This PR includes addition of env X_CSI_POWERFLEX_KUBE_NODE_NAME that is required in the PowerFlex driver to fetch the node labels.

Which issue(s) is this PR associated with:

Special notes for your reviewer:

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

@suryagupta4 suryagupta4 self-assigned this Jan 8, 2024
@suryagupta4 suryagupta4 changed the base branch from main to release-v1.10.0 January 8, 2024 06:42
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanmydell
Copy link
Contributor

@suryagupta4 : Do installation wizard needs changes for this variable?

@suryagupta4
Copy link
Contributor Author

@suryagupta4 : Do installation wizard needs changes for this variable?

@shanmydell : No, installation wizard does not require this change.

@shanmydell shanmydell merged commit 63e2708 into release-v1.10.0 Jan 9, 2024
4 checks passed
@shanmydell shanmydell deleted the node-labels-pflex branch January 9, 2024 05:44
AkshaySainiDell pushed a commit that referenced this pull request Jan 23, 2024
rishabhatdell pushed a commit that referenced this pull request Mar 20, 2024
rishabhatdell pushed a commit that referenced this pull request Mar 20, 2024
HarishH-DELL added a commit that referenced this pull request Mar 20, 2024
* Release v1.9.1 (#364)

* Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354)

* Update cosi image in chart (#359)

* revert kube node name changes (#361)

* Removing csm changes (#363)

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>

* Update Chart.yaml (#365)

* update helm releaser (#366)

* update csm chart for v2.9.1 (#369)

* Release v1.9.3 (#376)

* CSM 1.9.3

* csm version bump (#375)

* Update Chart.yaml (#379)

---------

Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>

* Update Chart.yaml with new versions (#380)

* added env for kube node name (#347)

* Driver and Modules Version Update (#348)

* Updating helm charts to support k8s 1.29.0 (#358)

* Disabling leader election for v1.10.0 (#360)

* [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353)

* expose proxy-server by ip address of master node

* fix spacing

* use local pv for redis by default

* remove period

* recycle pv

* update authorization.hostname comment

* Bumping reverseproxy version (#371)

* COSI driver verion bump up (#370)

* CSI-Sidecars version bumpup (#372)

* CSI-Sidecars version bumpup

* Snapshotter patch version update

* Mapping /opt/emc inside SDC container (#373)

* Mapping /opt/emc inside SDC container

* Updating path type

* app mobility version bump (#374)

* change default value (#381)

* version bumps (#378)

* Updated CSI Metadata Version (#382)

* app mobility version fix

* Update app mobility Chart

---------

Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>
@HarishH-DELL HarishH-DELL mentioned this pull request Mar 20, 2024
3 tasks
HarishH-DELL added a commit that referenced this pull request Mar 20, 2024
* Conflict fix verified (#388)

* Release v1.9.1 (#364)

* Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354)

* Update cosi image in chart (#359)

* revert kube node name changes (#361)

* Removing csm changes (#363)

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>

* Update Chart.yaml (#365)

* update helm releaser (#366)

* update csm chart for v2.9.1 (#369)

* Release v1.9.3 (#376)

* CSM 1.9.3

* csm version bump (#375)

* Update Chart.yaml (#379)

---------

Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>

* Update Chart.yaml with new versions (#380)

* added env for kube node name (#347)

* Driver and Modules Version Update (#348)

* Updating helm charts to support k8s 1.29.0 (#358)

* Disabling leader election for v1.10.0 (#360)

* [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353)

* expose proxy-server by ip address of master node

* fix spacing

* use local pv for redis by default

* remove period

* recycle pv

* update authorization.hostname comment

* Bumping reverseproxy version (#371)

* COSI driver verion bump up (#370)

* CSI-Sidecars version bumpup (#372)

* CSI-Sidecars version bumpup

* Snapshotter patch version update

* Mapping /opt/emc inside SDC container (#373)

* Mapping /opt/emc inside SDC container

* Updating path type

* app mobility version bump (#374)

* change default value (#381)

* version bumps (#378)

* Updated CSI Metadata Version (#382)

* app mobility version fix

* Update app mobility Chart

---------

Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>

* AM version  reverted

---------

Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>
hoppea2 added a commit that referenced this pull request Mar 20, 2024
* Release v1.9.1 (#364)

* Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354)

* Update cosi image in chart (#359)

* revert kube node name changes (#361)

* Removing csm changes (#363)

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>

* Update Chart.yaml (#365)

* update helm releaser (#366)

* update csm chart for v2.9.1 (#369)

* Release v1.9.3 (#376)

* CSM 1.9.3

* csm version bump (#375)

* Update Chart.yaml (#379)

---------

Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>

* Update Chart.yaml with new versions (#380)

* added env for kube node name (#347)

* Driver and Modules Version Update (#348)

* Updating helm charts to support k8s 1.29.0 (#358)

* Disabling leader election for v1.10.0 (#360)

* [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353)

* expose proxy-server by ip address of master node

* fix spacing

* use local pv for redis by default

* remove period

* recycle pv

* update authorization.hostname comment

* Bumping reverseproxy version (#371)

* COSI driver verion bump up (#370)

* CSI-Sidecars version bumpup (#372)

* CSI-Sidecars version bumpup

* Snapshotter patch version update

* Mapping /opt/emc inside SDC container (#373)

* Mapping /opt/emc inside SDC container

* Updating path type

* app mobility version bump (#374)

* change default value (#381)

* version bumps (#378)

* Updated CSI Metadata Version (#382)

* app mobility version fix

* Update app mobility Chart

---------

Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: HarishH-DELL <109663924+HarishH-DELL@users.noreply.github.com>
hoppea2 added a commit that referenced this pull request Mar 20, 2024
* added env for kube node name (#347)

* Driver and Modules Version Update (#348)

* Updating helm charts to support k8s 1.29.0 (#358)

* Disabling leader election for v1.10.0 (#360)

* [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353)

* expose proxy-server by ip address of master node

* fix spacing

* use local pv for redis by default

* remove period

* recycle pv

* update authorization.hostname comment

* Bumping reverseproxy version (#371)

* COSI driver verion bump up (#370)

* CSI-Sidecars version bumpup (#372)

* CSI-Sidecars version bumpup

* Snapshotter patch version update

* Mapping /opt/emc inside SDC container (#373)

* Mapping /opt/emc inside SDC container

* Updating path type

* app mobility version bump (#374)

* change default value (#381)

* version bumps (#378)

* Updated CSI Metadata Version (#382)

* added env for kube node name (#347)

* Driver and Modules Version Update (#348)

* Updating helm charts to support k8s 1.29.0 (#358)

* Disabling leader election for v1.10.0 (#360)

* [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353)

* expose proxy-server by ip address of master node

* fix spacing

* use local pv for redis by default

* remove period

* recycle pv

* update authorization.hostname comment

* Bumping reverseproxy version (#371)

* COSI driver verion bump up (#370)

* CSI-Sidecars version bumpup (#372)

* CSI-Sidecars version bumpup

* Snapshotter patch version update

* Mapping /opt/emc inside SDC container (#373)

* Mapping /opt/emc inside SDC container

* Updating path type

* app mobility version bump (#374)

* change default value (#381)

* version bumps (#378)

* Updated CSI Metadata Version (#382)

* app mobility version fix

* Update app mobility Chart

* Conflict fix verified (#388) (#389)

* Conflict fix verified (#388)

* Release v1.9.1 (#364)

* Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354)

* Update cosi image in chart (#359)

* revert kube node name changes (#361)

* Removing csm changes (#363)

---------

Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>

* Update Chart.yaml (#365)

* update helm releaser (#366)

* update csm chart for v2.9.1 (#369)

* Release v1.9.3 (#376)

* CSM 1.9.3

* csm version bump (#375)

* Update Chart.yaml (#379)

---------

Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>

* Update Chart.yaml with new versions (#380)

* added env for kube node name (#347)

* Driver and Modules Version Update (#348)

* Updating helm charts to support k8s 1.29.0 (#358)

* Disabling leader election for v1.10.0 (#360)

* [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353)

* expose proxy-server by ip address of master node

* fix spacing

* use local pv for redis by default

* remove period

* recycle pv

* update authorization.hostname comment

* Bumping reverseproxy version (#371)

* COSI driver verion bump up (#370)

* CSI-Sidecars version bumpup (#372)

* CSI-Sidecars version bumpup

* Snapshotter patch version update

* Mapping /opt/emc inside SDC container (#373)

* Mapping /opt/emc inside SDC container

* Updating path type

* app mobility version bump (#374)

* change default value (#381)

* version bumps (#378)

* Updated CSI Metadata Version (#382)

* app mobility version fix

* Update app mobility Chart

---------

Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>

* AM version  reverted

---------

Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>

* Reverted the CSM file to main (#390)

* Reverted changes

* Reverted the space

---------

Co-authored-by: Surya Gupta <109594002+suryagupta4@users.noreply.github.com>
Co-authored-by: Rishabh Raj <120644626+rishabhatdell@users.noreply.github.com>
Co-authored-by: hoppea2 <33433874+hoppea2@users.noreply.github.com>
Co-authored-by: Adarsh Kumar Yadav <109620911+adarsh-dell@users.noreply.github.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: boyamurthy <92081029+boyamurthy@users.noreply.github.com>
Co-authored-by: Rishabh Raj <rishabh.raj2@dell.com>
Co-authored-by: KerryKovacevic <140824885+KerryKovacevic@users.noreply.github.com>
Co-authored-by: Akshay Saini <109056238+AkshaySainiDell@users.noreply.github.com>
Co-authored-by: Bartosz Ciesielczyk <120648697+cbartoszDell@users.noreply.github.com>
Co-authored-by: KshitijaKakde <111420075+KshitijaKakde@users.noreply.github.com>
Co-authored-by: Jooseppi Luna <jooseppi_luna@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants