Correctly check ROOT version #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @peremato, since he encountered the problem. |
|
Many thanks for this pull request! |
|
Unfortunately this is not sufficient. We need also to install the header files that have been used generating ROOT dictionaries. |
|
I was referring to version 3.4.0. Probably is OK in the master now. |
It was fixed with commit 9259bfe |
|
Still, I forgot one version check in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the check may not have worked when using ROOT 6.0.0. Also, the check now uses the recommended
VERSION_LESSinstead of a normalLESSCMake condition.