Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint expr not formatted during commit action #1971

Closed
ion-elgreco opened this issue Dec 14, 2023 · 2 comments · Fixed by #1985
Closed

Constraint expr not formatted during commit action #1971

ion-elgreco opened this issue Dec 14, 2023 · 2 comments · Fixed by #1985
Assignees
@Blajda
Labels
bug Something isn't working

Comments

@ion-elgreco
Copy link
Collaborator

Currently when you write a constraint expr, the expr is not formatted on write, so you could end up with these expressions in the log:

'delta.constraints.value_gt_5': 'foo >0',

Maybe it's good if we format them before writing.
@ion-elgreco ion-elgreco added the bug Something isn't working label Dec 14, 2023
@Blajda
Copy link
Collaborator

Blajda commented Dec 19, 2023

take

@Blajda Blajda self-assigned this Dec 19, 2023
@Blajda Blajda mentioned this issue Dec 19, 2023
Merged
roeap pushed a commit that referenced this issue Dec 19, 2023
@Blajda
fix: implement consistent formatting for constraint expressions (#1985)
f6d2061 
# Description
Implements consistent formatting for constraint expressions so something
like `value < 1000` is normalized to `value < 1000`


Also includes drive by improvements.
1. Test & Fix that Datafusion expressions can actually be used when
adding a constraint
2. Test & Fix that constraints can be added to column with
capitalization
 
# Related Issue(s)
- closes #1971
@scarman-db
Copy link
Contributor

Okay so this is why there were bits that confused me when I looked at the check constraint impl today. :-D thanks @Blajda appreciate the help here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blajda Blajda

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement consistent formatting for constraint expressions Blajda/delta-rs
3 participants
@Blajda @ion-elgreco @scarman-db