Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proposed updated CODEOWNERS to allow better review notifications #1646

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Sep 20, 2023

Based on current pull request feedback and maintenance trends I'm suggesting these rules to get the right people on the reviews by default.

Closes #1553

Based on current pull request feedback and maintenance trends I'm suggesting
these rules to get the right people on the reviews by default.

Closes delta-io#1553
@github-actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@rtyler rtyler changed the title Proposed updated CODEOWNERS to allow better review notifications chore: proposed updated CODEOWNERS to allow better review notifications Sep 20, 2023
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we might want to add @MrPowers as a maintainer if we want to add him to this list.

Otherwise looks good to me. Worth keeping this open for a few days to collect feedback though.

@MrPowers
Copy link
Collaborator

Yea would love to be a maintainer to help out more!

@rtyler rtyler marked this pull request as ready for review September 25, 2023 17:05
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - I think we need to give @MrPowers access to the repo, at least GH ist complaining :)

@rtyler rtyler merged commit a482e4f into delta-io:main Sep 25, 2023
21 checks passed
@rtyler rtyler deleted the update-codeowners branch September 25, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the CODEOWNERS to capture the current reviewers and contributors
4 participants