fix: add missing pandas import #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Haarman
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
ion-elgreco
force-pushed
the
fix_pandas_import
branch
from
479efe1
to
cb9ec40
Compare
|
@Tim-Haarman Thanks! |
ion-elgreco
approved these changes
Jan 26, 2024
RobinLin666
pushed a commit
to RobinLin666/delta-rs
that referenced
this pull request
Feb 2, 2024
# Description Pandas was only imported for static type checking, but was actually used in the code of the module leading to import errors. Added the import similarly to `writer.py`, and updated the pandas alias in the type hints from 'pandas' to 'pd'. # Related Issue(s) - closes delta-io#2112 # Documentation x Co-authored-by: Tim Haarman <t.r.haarman@live.nl> Co-authored-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pandas was only imported for static type checking, but was actually used in the code of the module leading to import errors. Added the import similarly to
writer.py, and updated the pandas alias in the type hints from 'pandas' to 'pd'.Related Issue(s)
Documentation
x