[1321] Make update command return the number of updated rows. #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Peña <cdpm42@gmail.com>
scottsand-db
requested changes
Aug 12, 2022
| @@ -22,18 +22,18 @@ import org.apache.spark.sql.delta.actions.{AddCDCFile, AddFile, FileAction} | |||
| import org.apache.spark.sql.delta.commands.cdc.CDCReader.{CDC_TYPE_COLUMN_NAME, CDC_TYPE_NOT_CDC, CDC_TYPE_UPDATE_POSTIMAGE, CDC_TYPE_UPDATE_PREIMAGE} | |||
| import org.apache.spark.sql.delta.files.{TahoeBatchFileIndex, TahoeFileIndex} | |||
| import org.apache.hadoop.fs.Path | |||
|
|
|||
There was a problem hiding this comment.
nit: we have blank lines separating our import groups, so the above group is other and the below group is org.apache.spark. So add back the blank line please.
| @@ -51,6 +51,10 @@ case class UpdateCommand( | |||
| condition: Option[Expression]) | |||
| extends LeafRunnableCommand with DeltaCommand { | |||
|
|
|||
| override val output: Seq[Attribute] = { | |||
| Seq(AttributeReference("num_updated_rows", LongType)()) | |||
There was a problem hiding this comment.
I should've clarified this in the issue, my bad.
Can you make this num_affected_rows please? To be consistent with the DELETE command output.
Signed-off-by: Carlos Peña <cdpm42@gmail.com>
scottsand-db
approved these changes
Aug 12, 2022
|
Thanks @scottsand-db! |
allisonport-db
pushed a commit
to allisonport-db/delta
that referenced
this pull request
Aug 25, 2022
## Description This PR makes the `UPDATE` command return the number of updated rows. The update command returns the following output:  Modified existing tests. Closes delta-io#1331 Signed-off-by: Scott Sandre <scott.sandre@databricks.com> GitOrigin-RevId: a00cdd1a8a4e10dae5afece4ec5414d9bc9fde89 GitOrigin-RevId: 160dce9de1a1e34a29d47c6e21c9117f151b9a30 GitOrigin-RevId: 71f954cfcaf4d3a14e0a0693525a577bd0898d3f (cherry picked from commit b71ad65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1321.
How was this patch tested?
Modified existing tests.
Does this PR introduce any user-facing changes?
Yes. The update command returns the following output: