[Spark] Support for reading log compactions #2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
117
to
123
| case DeltaFile(f, fileVersion) => | ||
| (f, FileType.DELTA, fileVersion) | ||
| case CompactedDeltaFile(f, startVersion, endVersion) | ||
| if includeMinorCompactions && versionToLoad.forall(endVersion <= _) => | ||
| (f, FileType.COMPACTED_DELTA, startVersion) | ||
| case CheckpointFile(f, fileVersion) if f.getLen > 0 => | ||
| (f, FileType.CHECKPOINT, fileVersion) |
There was a problem hiding this comment.
I don't see any use of the middle element of this triple? The version is used for takeWhile and the file status is what we actually return... but where is file type used?
| (version, version) | ||
| } | ||
|
|
||
| if (highestVersionSeen < startVersion && endVersion <= latestCommitVersion) { |
There was a problem hiding this comment.
This ensures we don't pick up overlapping compacted Deltas, right?
- First compaction can't straddle the starting version
- Neighboring compactions can't overlap
- Last compaction can't straddle latest version
We get a lot of work out of that one line, maybe worth a code comment?
Comment on lines
+389
to
+392
| if (Utils.isTesting) { | ||
| assert(false, s"Validation around Compacted deltas failed while creating Snapshot. " + | ||
| s"[${JsonUtils.toJson(eventData)}]") | ||
| } |
There was a problem hiding this comment.
What does this code do? It seems to fail unconditionally in testing, but it's not obvious why validation has failed at this point?
There was a problem hiding this comment.
adding comment before the val eventData.
prakharjain09
changed the title
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Oct 3, 2023
This PR adds read support for log compactions described here: delta-io#2072 Closes delta-io#2073 GitOrigin-RevId: 6f4a09c3fa09c303cdeb747c382cedcfda5a2a4c
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Oct 3, 2023
This PR adds read support for log compactions described here: delta-io#2072 Closes delta-io#2073 GitOrigin-RevId: 6f4a09c3fa09c303cdeb747c382cedcfda5a2a4c
Kimahriman
pushed a commit
to Kimahriman/delta
that referenced
this pull request
Oct 3, 2023
This PR adds read support for log compactions described here: delta-io#2072 Closes delta-io#2073 GitOrigin-RevId: 6f4a09c3fa09c303cdeb747c382cedcfda5a2a4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR adds read support for log compactions described here: #2072
How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No