This repository has been archived by the owner on Apr 9, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add VisionPublisher and Detection- and GeometrySupplier #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thumbnail
force-pushed
the
wrapperpacket-supplier
branch
from
February 12, 2018 15:47
3233ac0
to
0f684ed
Compare
thumbnail
changed the base branch from
fix-gamestate-deducers-split-goal-deducer
to
master
February 12, 2018 15:47
romni
reviewed
Feb 12, 2018
public final class GamePublisher implements Publisher<GameFrame> { | ||
private final Publisher<WrapperPacket> visionPublisher; | ||
private final Publisher<SSL_Referee> refboxPublisher; | ||
public final class GamePublisher<I extends WrapperPacketSupplier & SSLRefereeSupplier> implements Deducer<I, GameFrame> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be called GameDeducer
?
return Flux.from(refboxPublisher) | ||
.map(packet -> () -> new Referee.State( | ||
.map(SSLRefereeSupplier::getSSLReferee) | ||
.map(packet -> new Referee.State( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted
…le for unpacking the container
Mobile doesn't allow for changing the title; e.g. this is still WIP, because
|
romni
reviewed
Feb 13, 2018
.transform(new ParallelDeducer<>( | ||
new SSLVisionDeducer<>(), | ||
new SSLRefboxDeducer<>(), | ||
GameFrameWithoutGoals::new)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on r51 you want to have
<J extends Player.SetSupplier & GoalDimension.Supplier & Field.Supplier & Ball.SetSupplier>
GameFrameWithoutGoals(final J packet, final Referee.Supplier referee) {
in order to get rid of the explicit dependency on VisionPacket
romni
approved these changes
Feb 13, 2018
thumbnail
changed the title
Wrapperpacket supplier
Add VisionPublisher and Detection- and GeometrySupplier
Feb 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
A proposed main could be as follows: