Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to trigger a key exchange #293

Closed
holgerjakobs opened this issue Apr 12, 2018 · 69 comments
Closed

Explain how to trigger a key exchange #293

holgerjakobs opened this issue Apr 12, 2018 · 69 comments

Comments

@holgerjakobs
Copy link

0.16

Expected behavior
When a contact deletes and reinstalls Delta chat, my app still has his old, now invalid key, so it doesn't decrypt his messages, which show as unencryptable messages in regular mail client.

Deleting the contact would probably lead to a new key exchange. But unfortunately, deleting a contact which is "in use" is disallowed.

How to trigger a new key exchange?

Please repair!

@r10s
Copy link
Member

r10s commented Apr 12, 2018

Deleting the contact would probably lead to a new key exchange. But unfortunately, deleting a contact which is "in use" is disallowed.

yes, but keys are exchanged as well for existing contacts, so a deletion would not make things better.

How to trigger a new key exchange?

the person who cannot read a message eg. because of a new device should send a message "hey i cannot read your message, please send again" - the answer should be readable and the keys will be exchanged.

@testbird
Copy link

testbird commented Apr 13, 2018

the person who cannot read a message eg. because of a new device should send a message "hey i cannot read your message, please send again"

Is the person who cannot read a message getting an error that explains this? Like, "If you already have a prior deltachat installation you should transfer your keys from the other installation using the export/import or transfer message function. (If you send messages to contacts without having imported the preexisting key (using the new key of this installation), the encrypted answers of your contacts won't be readable on your other, older installations (which have the preexisting key).

@r10s
Copy link
Member

r10s commented Apr 13, 2018

Is the person who cannot read a message getting an error that explains this?

currently, there are no really clear advices, this could be improved.

@testbird
Copy link

Is there a current error message in the code to improve?

@r10s
Copy link
Member

r10s commented Apr 13, 2018

not yet, but i've just modified the code to have such an error message. the following text

The messsage was encrypted to a different setup.

Send any message to the contact to share your new
setup; eg. ask the contact to send the message again.

is currently shown in the message bubble if a message cannot be decrypted. Any suggestions and improvements welcome before we give this to the translators (@comradekingu :)

@testbird
Copy link

testbird commented Apr 13, 2018

Is there another regular cause for this than a re-installation? It could be more sensible to advice the local user towards key transfer instead of asking (all) contacts (and them get accustomed) to re-sending messages to and with a new key.

There are messages that can not be read, because they were not encrypted for your 
current setup. This happens, for example, if you use a new installation without importing 
a preexisting setup.

You should now import the setup from your older installation to the newer installation. 
(Using the "setup message" feature in the older installation, or through key-file export 
and import.)

If you don't import a preexisting setup, you will automatically share your new setup when
writing to contacts. But your contacts would then need to re-verify your new setup. 
And you would then not be able to read the replies with your old setups anymore, 
because the replies will then be encrypted for the new setup.

@testbird
Copy link

I modified the text to also be shown whenever DC finds non-decryptable messages on the server (after installation), and not only when viewing a new message.

@testbird
Copy link

The setup wizard could also emphasize to import a preexisting setup, if one exists. But I can't find it's text with the search function in the code.

@testbird
Copy link

testbird commented Apr 13, 2018

Shorter, without any explanation and problem warning:

Found a messsage that was encrypted for a different setup.

Most likely you need to import a preexisting setup into a new
installation (e.g. through a "setup message").

(could not find the commit)

@r10s
Copy link
Member

r10s commented Apr 14, 2018

Is there another regular cause for this than a re-installation?

might be that the sender used a key from a keyserver - either an old key or an key that was uploaded by another user.

@testbird
Copy link

testbird commented Apr 14, 2018

Ok, new try:

A message for you was encrypted for a different setup.

If this was not by mistake of the sender, it is likely you have made a new 
installation and need to transfer the preexisting setup (e.g. through 
a "setup message").

@r10s
Copy link
Member

r10s commented Apr 14, 2018

As the text will be written directly into the mail body (the "bubble") i would prefer this message over A message. Also, the Autocrypt Setup will only help if the recipient has really changed his setup. I think in many cases, it is a mistake of the sender and this should be fixed by asking him to send the message again. This "social" approach also work if the sender does not use Autocrypt.

Next iteration :)

This message was encrypted for another setup.

- to share your current setup, send any message to the
  contact, eg. ask the contact to send the message again.

- to import another setup, send an Autocrypt Setup Message
  from another device with the correct setup

@testbird
Copy link

text will be written directly into the mail body

Makes sense then.
I think it's ok, but listing the import as first option might save some hurried users from the annoyances that arise when changing setup.

This message was encrypted for another setup.

- The correct setup may be imported, eg. by sending an Autocrypt Setup Message
  from the correct device to this device.

- The current setup may be used instead, by sending a new message to the
  contact, eg. asking the contact to send the message again.

@r10s r10s changed the title Cannot remove contact To to trigger a key exchange Apr 16, 2018
@r10s r10s changed the title To to trigger a key exchange How to trigger a key exchange Apr 16, 2018
@r10s r10s changed the title How to trigger a key exchange Explain how to trigger a key exchange Apr 16, 2018
@r10s
Copy link
Member

r10s commented Apr 16, 2018

The term correct is difficult here - we do not really know (1) if the sender has encrypted to the wrong setup or (2) if the received has messed up his setup. In my experience (1) is far more frequent - eg. it is very easy in Enigmail to encrypt to the wrong key - or just do not add a key for a CC'ed recipient.

This message was encrypted for another setup.

- To share your current setup, send any message to the
  contact, eg. asking the contact to send the message again.

- If you have just changed your setup on another device,
  you may want to import it by sending an
  Autocrypt Setup Message from there.

What do you think?

EDIT: I changed the title, it took me ten minutes to find this issue by the old title :)

@testbird
Copy link

testbird commented Apr 16, 2018

Yea, some basic explanation is needed.
So I added some to the other option as well.

This message was encrypted for another setup.

- If you made a new installation and possibly see this error instead of multiple messages: 
You should import the older, preexisting setup, eg. by sending an Autocrypt Setup 
Message to yourself from your first device to the second, to be able to read all your 
messages on all your devices.

- If this is only a singular unreadable message, because a sender mistakenly didn't 
encrypt for your setup: You may use and share your current setup, by sending a new 
message to the contact, eg. asking the contact to send the message again.

Don't you think it would make sense to list the case first

  • that happens with just DC-only users (phone heads only, no computer users involved)
  • that is easier to exclude

@r10s
Copy link
Member

r10s commented Apr 16, 2018

Don't you think it would make sense to list the case that happens with just DC-only users (no expert involved) first?

Not sure. I think a typical DC user has never used PGP before and uses only one device. These users may more likely be confronted with users that encrypt to an unknown key.

I like your explanations, however, maybe we can make it a little shorter:

This message was encrypted for another setup.

- If you made a new installation on another device:
  You can import that setup it by sending an Autocrypt Setup Message from there.

- The sender may mistakenly didn't encrypt for your setup:
  To share your current setup, send any message to the contact,
  eg. asking the contact to send the message again.

I dropped the hint regarding the number of messages - typically, when the users is confronted with the situation, there is only one message - more errors may follow, but the user cannot know.

I think we get closer :)

@testbird
Copy link

testbird commented Apr 16, 2018

Yea, right the user may only see one at a time. Kept it shorter and with should vs may, hopefully clearing up the options, and removed typos.

  • If you made a new installation on another device:
    You can import that setup it by sending an Autocrypt Setup Message from there.

Changed this to keeping the old instead of sending from the new:

This message was encrypted for another setup.

- If you made a new installation:
  You should import your older, preexisting setup, 
  eg. send an Autocrypt Setup Message to yourself from your first device.

- If the sender may not have encrypted for your setup by mistake:
  You may use and share your current setup, by sending a new 
  message to the contact, eg. asking the contact to send the message again.

@testbird
Copy link

typical DC user has never used PGP before and uses only one device.

OTOH it may also be relevant when typical users buy or switch to a new device.

@r10s
Copy link
Member

r10s commented Apr 16, 2018

  • yes, the new installation may also be on this device.
  • Autocrypt Setup Messages are always sent to oneself, so there is no need for a special hint
  • removed "If" from the second point - the user cannot decide, so there is no if-this-then-that advice, the "cannot read" message is the only solution to solve the problem (but a simple one)
  • btw. regarding that logic. it is better to keep the order as you suggested - if setup-changed, transfer setup, else ask user to send again.
  • following your suggestion regarding "a new message" (instead of "any message")
This message was encrypted for another setup.

- If you made a new installation:
  You can use your preexisting setup eg. by sending an 
  Autocrypt Setup Message from your first device.

- The sender may mistakenly didn't encrypt for your setup:
  To share your current setup, send a new message to the contact,
  eg. asking the contact to send the message again.

Have not discussed so much about a single message :) however, i think it is worth the effort :)

@r10s
Copy link
Member

r10s commented Apr 16, 2018

"The sender may mistakenly didn't encrypt for your setup" - not sure about the grammar btw.

@testbird
Copy link

testbird commented Apr 16, 2018

Yes, it's worth here, because good advice should make things "easy in the end",

EDIT: and avoid worse problems down the road, including puzzled and likely negative users.

I used "should vs. may", to avoid users stumbling into the problems of using two keys on different devices.

To keep the "advice flow" maybe the second point could start with "Otherwise, the sender may mistakenly not have encrypted for your setup". (I think it's "have".)

This message was encrypted for another setup.

- If you made a new installation:
  You should use your preexisting setup, eg. by sending an 
  Autocrypt Setup Message from your first device.

- Otherwise, the sender may have mistakenly not encrypted for your setup:
  Send a new message to the contact (automatically sharing your current setup) 
  and ask the contact to send the message again.

@r10s
Copy link
Member

r10s commented Apr 16, 2018

Great, we're getting really close.

  • i would use "You can use your preexisting setup ..." - the user may have made a new installation but does not want to import the old setup - in this case, he has to share the new one.
  • I would begin the second point with what will happen, this would also be in line with the first point: to use preexisting setup - do this - to share current setup - do that
This message was encrypted for another setup.

- If you made a new installation:
  You can use your preexisting setup, eg. by sending an 
  Autocrypt Setup Message from your first device.

- Otherwise, the sender may have mistakenly not encrypted for your setup:
  To share your current setup, send a new message to the contact
  and ask the contact to send the message again.

@r10s
Copy link
Member

r10s commented Apr 16, 2018

OTOH, your Send a new message to the contact (automatically sharing your current setup) is also fine as this makes the automatic sharing more clear. Probably it is even better.

@Ampli-fier
Copy link
Contributor

I fear it is not so obvious, what is meant by "the setup".

@r10s
Copy link
Member

r10s commented Apr 16, 2018

@Ampli-fier This is Autocrypt-slang :) we do not want to speak about keys as this is even more abstract for unaware people. And Autocrypt-clients use eg. the term "Setup message", "Transfer Setup" and so on.

@testbird
Copy link

testbird commented Apr 16, 2018

(automatically sharing your current setup)

Ampli-fier is right, the use of setup in this variant is confusing. Setup should probably only refer to the private key part?

Edit: Oops, other version has the same problem.

"To share your current setup" => "To use your current setup"?
Share may sound too much like a transmission (setup message).

@testbird
Copy link

testbird commented Apr 16, 2018

This message was encrypted for another setup.

- If you made a new installation:
  You can import your preexisting setup, eg. by sending an 
  Autocrypt Setup Message from your first device.

- Otherwise, the sender may have mistakenly not encrypted for your setup:
  To keep using your current setup, just reply and
  ask the sender to send the message again.
  • 1st: use => import
  • 2nd: share => keep using, just
  • 2nd: contact => sender
  • 2nd: send a new message to the sender => reply

@testbird
Copy link

testbird commented Apr 16, 2018

If I made a new installation, it must not mean that I still have an old "setup" that makes it possible to use Autocrypt transfer ...

Right.
Slightly adapted:

  • if used before and available
  • can import, and usually should,
  • menu location, otherwise and
  • To keep using
  • ask to verify and send again.
  • Delta Chat setup
  • not encrypted for current setup
This message was not encrypted for your current Delta Chat (autocrypt) setup.

- If you were using another installation before, that is still available:
  You can import the setup, and usually should, eg. by going to 
  "Configuration -> Send Setup Message" at your first device.

- Otherwise, and if the sender may not have encrypted for your setup by mistake:
  Keep using your current setup, by replying and
  asking the sender to verify and send the message again.

@testbird
Copy link

most of your future user base will not be aware of Delta encrypting feature.

Yes, that's why this message is rather crucial. It can be the first contact with this feature, and the single chance to shine and explain.

@Ampli-fier
Copy link
Contributor

@testbird
The average user has no idea, what Setup could mean. The user went to Google Play Store, installed DC and uses the app.

@testbird
Copy link

testbird commented Apr 17, 2018

Sure, the user does not have to know every detail about the server, pgp, db setup etc., but the first thing the app is used for, if I am not mistaken, seems to be: The user configures the email setup.

Thus "setup" seems to be a useful, basic word with a common meaning, nothing special. Of course the configuration in DC could make sure to also actually use the word "setup", if it is not already used, to make it better recognizable when referring to it in the error message advise.

@testbird
Copy link

testbird commented Apr 17, 2018

What about: This message was encrypted for another Delta Chat (autocrypt) setup.

May that improve it in your sense, Ampli-fier?

Edit: made the adaptions in the last version above

@r10s
Copy link
Member

r10s commented Apr 17, 2018

@testbird

It might already help
And, unfortunately, it might also make your contacts use different keys and get things out of order...

worst case: if the receiver decides to import his new setup after sending a message to the contact (because he did not read the full message ...), this message will pop up again and he can "repair" the keys by sending a key again.
in the majority of cases, the user will see the message when he has not changed his setup and the message will fix the problem immediately.

Thus, probably better to mention importing the setup and, and directly mention solutions. (Helpful advice is not puzzling. A link is still good.)

The other device may be a non-delta-client, so instruction will probably get too long, I think @Ampli-fier suggestion (#293 (comment)) is still fine.

@r10s
Copy link
Member

r10s commented Apr 17, 2018

this is what the message looks like in delta then; btw. maybe a direct link is not a good idea as this may make it easier for phishers to trick users that have learned to click on links in messages that cannot be encrypted ... maybe we should just write "see 'Help' for details".

btw. it's not necessarily a re-installation of Delta Chat causing the problem in the second point - it may also be Thunderbird, K-9 or others. so maybe "In case you re-installed Delta Chat or another E-Mail-Program on this or another device ..."

screenshot_1523963827

@r10s
Copy link
Member

r10s commented Apr 17, 2018

update: i also removed the hint to the help - the help should be opened on the newly installed device / E-Mail-Prorgram, so I think the user should search for help there. Added a hint to the Autocrypt Setup Message instead, more experienced users will know what other pgp-alternatives they have, i think.

screenshot_1523965093

@testbird
Copy link

testbird commented Apr 17, 2018

Encrypted Message - [This message cannot be decrypted.

  • It might already help to simply reply to this message and ask the
    sender to send the message again.

Should users get accustomed to re-send messages to new keys upon requests?

So what is the average user supposed to do after reading this? The user notices this was not a meaningful message, rather a reference blob. Go read the doc? Learn what applies and decide between options? I think this message doesn't yet help the user as much as it should.


help should be opened on the newly installed device / E-Mail-Prorgram, so I think the user should search for help there.

  1. Why on the newly installed device? I was thinking the user usually sees above message on the new device, for new incoming messages. And only if the user sends a message from a new install (wasn't adviced to, or against the advice to, transfer the setup during the install), and the message was replied to, the message might be seen on the older install.
  2. Doesn't the setup message have to be sent from the device that was first installed (and used)?

btw. it's not necessarily a re-installation of Delta Chat causing the problem in the second point - it may also be Thunderbird, K-9 or others. so maybe "In case you re-installed Delta Chat or another E-Mail-Program on this or another device ..."

Right, it might be some other autocrypt install.
Thanks for thinking and testing the message for of all these different cases.

This message was not encrypted for your current (Delta Chat) autocrypt setup.

- If you have been using another installation before (and it is still available):
  You can transfer the setup, and usually should, eg. (in Delta Chat) by going to 
  "Configuration -> Email Account Setup -> Send Autocrypt Setup Message" 
  on the device that you installed first.

- Otherwise (and if the sender may not have encrypted for your setup, by mistake):
  Keep using your current setup, by replying and
  asking the sender to verify and send the message again.

The and if the sender may not have encrypted for your setup by mistake isn't strictly needed, but provides a hint that the sender might have to fix something.

@testbird
Copy link

testbird commented Apr 17, 2018

I think this message doesn't yet help the user as much as it should.

A specific risk of the seemingly easy "just reply" advice would be to lead to a very frustrating ping-pong effect, or not?
Therefore my emphasizing of proper advice to import during install (setup wizard) and on error (the message at hand).

@testbird
Copy link

testbird commented Apr 17, 2018

What could still be improved seems to be the consistency of managing the (Delta Chat) autocrypt setup.

  • Let references use the same words in all places
  • Maybe consolidate and show the transferable setup details in the "Name and Status" subpage (rename it to Email Account Setup)?
  • Rename and move the "start autocrypt-key-transfer" menu button to "Send Autocrypt Setup Message" in the "Email Account Setup" page?

@r10s
Copy link
Member

r10s commented Apr 17, 2018

Should users get accustomed to re-send messages to new keys upon requests?

well, it's the request from a known friend they've contacted before, i think this could be a working "social" protocol. if there's any doubt they can ask or do an out-of-band verification.

A specific risk of the seemingly easy "just reply" advice would be to lead to a very frustrating ping-pong effect, or not?

no. the sender gets the new key when receiving "please send the message again" and is able to encrypt correctly then.

Therefore my emphasizing of proper advice to import during install (setup wizard) and on error (the message at hand).

Yes, on install, we can be more specific, but this is another issue :)
When receiving the error, this issue is about, the most common problem is a different one, imho.

Rename and move the "start autocrypt-key-transfer" menu button to "Send Autocrypt Setup Message" in the "Email Account Setup" page?

Yes, "Send Autocrypt Setup Message" is far better; K-9 will also use this term, see thunderbird/thunderbird-android#3342

btw. what does K-9 or Enigmail display in these cases?

@testbird
Copy link

testbird commented Apr 17, 2018

A specific risk of the seemingly easy "just reply" advice would be to lead to a very frustrating ping-pong effect, or not?

no. the sender gets the new key when receiving "please send the message again" and is able to encrypt correctly then.

That's only one half of what happens, if I understand this correctly:

Suppose, user A has made new install a2 and receives a message from an old friend F (designated for a1).

Instead of importing the a1 setup, A replies to the message from a2 and asks to re-send the message.

F gets the reply and re-sends the message to a2.

Now, A can read the message at its second installation a2.

However, the message is now not readable at the first installation a1, and following the "just reply" advice on a1 will just lead to a frustrating ping-pong loop, switching back and forth between a1 and a2.

@r10s
Copy link
Member

r10s commented Apr 17, 2018

that's correct if the user has made a second installation which requires an Autocrypt Setup Message that is handled in advice 2.

if there is no new installation (i think this is the more frequent case) and the message is shown, the advice to "just reply" would normally fix the problem.

i think this is fine. maybe we can just give the current text a try, and see what will happen.

@testbird
Copy link

testbird commented Apr 17, 2018

that's correct if the user has made a second installation which requires an Autocrypt Setup Message that is handled in advice 2.

Ok, then the message should definitely handle that case first, just as discovered before...

regarding that logic. it is better to keep the order as you suggested - if setup-changed, transfer setup, else ask user to send again

It's an easy condition to exclude for a user anyway. As the ping-pong consequence warrants it, using "should" or even "need" in the message even simplifies it further.

maybe we can just give the current text a try, and see what will happen.

I made adapted versions for both drafts:

This message was not encrypted for your current (Delta Chat) autocrypt setup.

- If you have been using another installation before (and it is still available):
  You need to transfer the setup, eg. (Delta Chat) by going to 
  "Configuration -> Email Account Setup -> Send Autocrypt Setup Message" 
  on the device that you installed first.

- Otherwise (and if the sender may not have encrypted for your setup, by mistake):
  Keep using your current setup, by replying and
  asking the sender to verify and send the message again.
This message can not be decrypted.

* In case you have been using another installation of Delta Chat or an (autocrypt) 
  E-Mail program before,
  you need to import the setup, eg. by sending an Autocrypt Setup Message from there.

* Otherwise, simply reply to this message, and ask the sender 
  to verify and send the message again.
  (Only without autocrypt, will the sender have to adapt the encryption settings manually.)

@Ji-eF
Copy link

Ji-eF commented Apr 17, 2018

The first one is too hard to read

For the second, there's a repetition, but it's easier to read :

you need to import the setup by sending an Autocrypt Setup Message from there.

@Ji-eF
Copy link

Ji-eF commented Apr 17, 2018

This message can not be decrypted.
* Import your keys from the previous installation of Delta-Chat (or E-mail program [unnecessary?])
* Easy solution : Ask the sender to send back this message.
  Drawback : You won't be able to read your previous messages anymore.

@testbird
Copy link

testbird commented Apr 17, 2018

Thanks Ji-eF, I removed the repetition as you suggested, but kept the ", eg." to hint that there are other ways to export and import the key, ok?

Or, adapting with your draft:

This message can not be decrypted (with your current autocrypt setup).

* If you've previously used another autocrypt installation (Delta Chat or other), 
  you might still have to import your older setup,
  eg. use "Send Autocrypt Setup Message" there.

* Otherwise, simply reply to this message (announces current setup),
  and ask the sender to verify and send the message again.

The drawback (ping-pong) is even worse, but maybe it doesn't need to be mentioned with clear "you should/only otherwise" wording.

@testbird
Copy link

testbird commented Apr 17, 2018

maybe we can just give the current text a try, and see what will happen.

I have qualms about that. See what can happen, if users follow that advice:

Suppose again, the user A is at a new installation (a2), and reads:

  • It might already help to simply reply to this message and ask the sender to send the message again.

Then simply tries this. But afterwards can't read further messages on the old installation (a1). So this time decides to follow the second advice:

  • In case you re-installed Delta Chat or another E-Mail-program on this or another device you may want to send an Autocrypt Setup Message from there.

Accordingly, user A sends a setup message from a2, which leads to overwriting the old a1 setup, and the key is lost, at least not send-able in setup messages anymore. :-(


I'd say the adapted Ji-eF inspired version (one post above) should be safer.

@testbird
Copy link

testbird commented Apr 20, 2018

I'll just provide a pull request to change the order of the advice, and saying "if used another ...should import, otherwise, ..."

#299

@r10s
Copy link
Member

r10s commented Apr 22, 2018

maybe this makes sense, but i personally would prefer the wording from @Ampli-fier , so what about:

This message cannot be decrypted.
• In case you re-installed Delta Chat or another E-Mail-program
  on this or another device you may want to send an Autocrypt Setup Message from there.
• Otherwise simply reply to this message and
  ask the sender to send the message again.

@testbird
Copy link

testbird commented Apr 22, 2018

If you read this or that above, doesn't it recommend to import from the re-installed (new) deltachat or email? I can't be sure? What about a new device/installation? And, it could be hard to find the "send autocrypt message" in any other email program. That's why the text in the pull request differs in the first point, and tries to associate things to the same words that are used in the menus and options (autocrypt, setup, verify), to enable the users to find their way with it.

Generally, I don't know if basic liking is a first rank criteria for error and help texts.
It seems to be a different idea than not to produce false ambiguities and follow-up problems, when avoidable.

Nevertheless, maybe I would like a little addy to the main error and "might have to" better than the "should":

This message cannot be decrypted (with your current autocrypt setup).

* If you've previously used another autocrypt installation (Delta Chat or other),
  you might still have to import your older setup, 
  eg. use "Send Autocrypt Setup Message" there.

* Otherwise, simply reply to this message (announces current setup),
  and ask the sender to verify and send the message again.

@r10s
Copy link
Member

r10s commented Apr 22, 2018

If you read this or that above, doesn't it recommend to import from the re-installed (new) deltachat or email?

i do not think that "you may want to" is more a recommendation than "you might still have to". it is true optional in my understanding.

And, it could be hard to find the "send autocrypt message" in any other email program.

this is true, but we cannot help on a little error message on this point - esp. as the "otherwise" part is the more likely one imho.

however, maybe it already gets too technical, also "share" may be misunderstood as being to close to a setup messages, see #293 (comment)

btw. asking the sender to "verify" - what would es expect the sender to do?

all in all, I think we cannot solve this 100% here, maybe this needs ui testing and more feedback.

i also think, the current text is not that bad and has no larger issues. so, for now, i would just keep it and go forward to other problems :)

@testbird
Copy link

testbird commented Apr 22, 2018

Yes, sure, nevermind.

It's just an uncomfy experience, that going forward with other problems, leaving small an reachable fixes aside "for now", tends to create more problems later (which are harder to re-approach (and take longer) later when things have evolved and the issue faded away).


i do not think that "you may want to" is more a recommendation than "you might still have to". it is true optional in my understanding.

Yes it's optional, but IMHO it would make sense to stress (even if just so lightly) that one should make sure to import the old setup, if not already done so (too avoid unecessary key changes (and thus further views of that error message, when old contacts write).

"verify" - what would es expect the sender to do?

I don't know the new features, thought you just implemented that, and that using a new setup makes users "unverified" at their contacts (and confuses contacts).

has no larger issues

What about erroneous advising to send setup message from the newer install (tablet -> phone, or new phone -> old phone)? #293 (comment)

If some nerd friend couln't manually set up an autocrypt key, thats not much of an issue, but unnecessary announcing a new setup (fork) still seems to be one to me?

"share" may be misunderstood

Yes, good point, maybe "announce"?

@comradekingu
Copy link
Contributor

comradekingu commented Apr 23, 2018

Unreadable message - it was encrypted with a public key you don't have the private counterpart to.

  • New Autocrypt installations generate new keys, import a key from an old one by sending an Autocrypt Setup message to it.

  • To keep using your current key, make sure you are talking to the right person through other private means, and ask the person to resend the message.

@r10s
Copy link
Member

r10s commented Apr 24, 2018

@comradekingu hi :)

  • in general, Autocrypt recommends not using the "key" language, "setup" seems to be better for new user, we also follow this approach in other parts.
  • setup messages are initiated by the "old setup", not by sending "an Autocrypt Setup message to it".

@testbird
Copy link

Autocrypt recommends not using the "key" language

That recommendation may, unfortunately, just go a little too far.

The word key is well known and generally understood -- only the "public key" concept has no analog --, it's easily understood that a key is needed to decrypt, and it should not be given away.

@comradekingu
Copy link
Contributor

Unreadable encrypted message

If it was meant for an old account of yours, send an Autocrypt Setup message from the old to your new device to read it, and older messages on that account.

To keep using this Autocrypt setup instead, make sure you are talking to the right person through other private means, and ask the person to resend the message.

@r10s
Copy link
Member

r10s commented May 25, 2018

i think, we can close this issue for now - if ui testing brings up new insights, we can think it over.

@r10s r10s closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants