Decrypt encrypted mails turned into attachments #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related forum thread: https://support.delta.chat/t/encryption-broken-in-one-direction/2076 |
link2xt
force-pushed
the
link2xt/mixed-up-google-workspace
branch
from
4b7f060
to
f082d53
Compare
link2xt
force-pushed
the
link2xt/mixed-up-google-workspace
branch
from
f082d53
to
0fcde7c
Compare
Google Workspace has an option "Append footer" which appends standard footer defined by administrator to all outgoing messages. However, there is no plain text part in encrypted messages sent by Delta Chat, so Google Workspace turn the message into multipart/mixed MIME, where the first part is an empty plaintext part with a footer and the second part is the original encrypted message. This commit makes Delta Chat attempt to repair such messages, similarly to how it already repairs "Mixed Up" MIME structure in `get_mixed_up_mime`.
link2xt
force-pushed
the
link2xt/mixed-up-google-workspace
branch
from
0fcde7c
to
7156642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Workspace has an option "Append footer" which appends standard
footer defined by administrator to all outgoing messages. However,
there is no plain text part in encrypted messages sent by Delta Chat,
so Google Workspace turn the message into multipart/mixed MIME, where
the first part is an empty plaintext part with a footer and the second
part is the original encrypted message.
This commit makes Delta Chat attempt to repair such messages,
similarly to how it already repairs "Mixed Up" MIME structure in
get_mixed_up_mime.