fix: always set correct chat_id for DC_EVENT_REACTIONS_CHANGED
#5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is_probably_private_reply()` checks if a message should better go to the one to one chat instead of the chat already identified by the `In-Reply-To`. this functionality is needed to make "Reply Privately" work. however, this functionality is never true for reactions. if we would return `true` here, own reactions seen by a second device would not get the correct chat assiged.
r10s
force-pushed
the
r10s/fix-multi-device-reactions
branch
from
5f965f5
to
3f315fe
Compare
link2xt
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR sets correct
chat_idforDC_EVENT_REACTIONS_CHANGEDevents.detection of correct chat-id went wrong sometimes somewhere deep inside
receive_imf(), i tried the most less intrusive fix (changingis_probably_private_reply(), see commit message for details) with probably few side effects, as changing too many things inreceive_imf()with good chance raises other issues :)also, it the
is_probably_private_reply()seems to be really the cause, changingreceive_imf()in a way that withoutallow_creationthe correct chat is still returned may be an alternative, however, feels wrong as it works around somehow and seems not be needed otherwise. also, it would need a deeper understanding ofreceive_imf()where i currently do not have the mindset for :)closes #5418